Skip to content

docs(structure): keep error-detail.md within its 600-line budget - #9029

Closed
lidge-jun wants to merge 1 commit into
devfrom
qb/fix-error-detail-budget
Closed

lidge-jun wants to merge 1 commit into
devfrom
qb/fix-error-detail-budget

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

dev currently fails bun run structure:check: structure/data-planes/error-detail.md is 601 lines, over the 600-line budget. #8968 and #8980 each kept the file within budget at their own heads; their union on dev (8ec6fdb) is one line over. This joins two lines of an existing test-file list, so the content is unchanged and the file is back to 600 lines.

Verification

  • bun run structure:check on this branch: structure/ SSOT checks passed (on dev 8ec6fdb and later it reports the 601-line failure).
  • bun test tests/ci-workflows/structure-ssot.test.ts: 51 pass, 0 fail.
  • Docs-only change; no runtime code touched.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Tests
    • Added a chat error collector verdicts test to the referenced test list.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 21, 2026 06:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T06:33:57.461387Z 13bf63e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The error-detail documentation now lists the collector-verdicts test alongside the server evidence test. No implementation behavior changes are shown.

Changes: Error-detail test references

Layer / File(s) Summary
Update test references
structure/data-planes/error-detail.md
The test list now places tests/responses/chat-error-collector-verdicts.test.ts alongside tests/server/server-chat-error-body-evidence.test.ts.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Suggested labels: documentation

Merge Risk: Minimal · up to 13bf6

This is a docs-only line join that restores the file's line budget without changing content or runtime behavior. No merge-blocking risk is apparent.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the docs-only change to structure/data-planes/error-detail.md, which joins two lines in an existing test-file list to bring the file back to its 600-line budget. The title is specific …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the docs-only change to structure/data-planes/error-detail.md, which joins two lines in an existing test-file list to bring the file back to its 600-line budget. The title is specific and matches the changeset's main purpose. It uses the conventional docs(scope) prefix and is a single concise sentence, with no file lists, emojis, or vague terms.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between eaeba52 and 13bf63e.

Files selected for processing: 1

  • structure/data-planes/error-detail.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Superseded by #9028 (53f2b20), which repaired the same error-detail.md budget on dev first. Closing without merge.

@lidge-jun lidge-jun closed this Nov 21, 2026
@lidge-jun
lidge-jun deleted the qb/fix-error-detail-budget branch November 21, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant