You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(windows): recognize Korean disabled and queued task states - #8976
Korean Windows can report a disabled Scheduler task as 사용 안 함 and a queued task as 대기. Both words currently produce an unknown state during checked stop. That sends an otherwise conclusive CSV answer to a fresh PowerShell process inside a one-second state-check budget.
Recognize both words in the existing state sets. A disabled task is inactive. A queued task is active because it can still launch. The two strings were independently matched to the English Disabled and Queued entries in the shipped Windows resource tables (string IDs 535 and 534).
Verification
Captured the original bytes from a Korean Windows machine using System32\schtasks.exe /query /tn opencodex-proxy /fo CSV /nh with a hidden child and redirected stdout, as in the CLI. The command exited 0 and returned four matching rows (156 bytes). Each state field contained BB E7 BF EB 20 BE C8 20 C7 D4. With Bun 1.4.4 and active locale ko-KR, the unchanged production decodeWindowsTextBytes decoded all four as 사용 안 함. The v2.100.5 parser returned unknown. On this PR the same bytes produced not-running, and the checked-stop state adapter needed only the named Scheduler query. A separate shell session on the same machine returned English Disabled. This was a read-only command and byte replay. It does not identify the output from an earlier GUI click.
Ran the v2.100.5 parser on CSV rows containing each Korean word. Both returned unknown. The new regression checks assert the disabled and queued classifications on the current development branch. A read-only Windows measurement of the PowerShell fallback took 3.6 s. These results establish a parsing defect independently of any particular Desktop update attempt.
Native Windows x64, Bun 1.4.4. bun --no-env-file --no-install scripts/test.ts --no-env-file --no-install --isolate --parallel=1 tests/windows/windows-checked-stop-live.test.ts passed all 28 tests (106 assertions). bun run typecheck passed for 2,681 files. bun run structure:check and git diff --check passed.
Compatibility with the Japanese-state PR #8959 at 40e67cc1: a local three-way merge identified one conflict, confined to the two state sets. Keeping the union of both additions passed 13 parser cases, including all four Japanese and all four Korean states. The tests and structure document merge automatically. If either PR lands first, the remaining change should retain both sets of localized words. The registration-read PR fix(windows): query the named task within the stop deadline #8974 merges cleanly with this patch.
Local validation focused on the affected parser and its checked-stop suite on a shared Windows workstation. Broader suite coverage is left to CI.
Checklist
Scope stays focused and avoids unrelated cleanup.
Docs or release notes were updated when needed.
Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.
Summary by CodeRabbit
Bug Fixes
Task Scheduler status checks now correctly recognize Korean “queued” and “disabled” labels, while continuing to report unrecognized labels as unknown.
Documentation
Clarified how queued and disabled Korean statuses are interpreted when determining whether a task is active.
No actionable comments were generated in the recent review.
Walkthrough
The CSV task-state parser now recognizes 대기 as running and 사용 안 함 as not running. The Korean status test and the Part A documentation cover these classifications.
Changes: Korean Task Scheduler status handling
Layer / File(s)
Summary
Classify Korean status labels src/service/windows-checked-stop-live.ts:130-131, tests/windows/windows-checked-stop-live.test.ts:172-176, structure/ops/windows-checked-stop.md:94-96
The parser classifies 대기 as running and 사용 안 함 as not running. The test checks both results. The documentation describes these statuses.
lidge-jun/opencodex#8959: Adds Japanese status labels to the same Task Scheduler CSV parser state sets.
lidge-jun/opencodex#8870: Changes localized status handling in the same parser, including Korean labels.
Merge Risk: Minimal · up to 37d9f
This change makes the Windows task-state parser recognize the Korean "disabled" and "queued" labels instead of returning unknown and falling back to a slower PowerShell query. The change is small and covered by a test, and no merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: the parser and checked-stop state sets now recognize the Korean disabled (사용 안 함) and queued (대기) Windows Scheduler states. The raw summary and objectives both describ…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: the parser and checked-stop state sets now recognize the Korean disabled (사용 안 함) and queued (대기) Windows Scheduler states. The raw summary and objectives both describe this same change to the Korean state labels, so the title matches the changeset. It is specific, short, and in a conventional commit format.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between d61cca1 and 37d9f42.
Files selected for processing: 3
src/service/windows-checked-stop-live.ts
structure/ops/windows-checked-stop.md
tests/windows/windows-checked-stop-live.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
Regression: tests/windows/windows-checked-stop-live.test.ts passes on this head (27 pass, 1 skip) and fails with src/service/windows-checked-stop-live.ts restored from dev (1 fail), run with the Bun 1.4.4 test runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Korean Windows can report a disabled Scheduler task as
사용 안 함and a queued task as대기. Both words currently produce an unknown state during checked stop. That sends an otherwise conclusive CSV answer to a fresh PowerShell process inside a one-second state-check budget.Recognize both words in the existing state sets. A disabled task is inactive. A queued task is active because it can still launch. The two strings were independently matched to the English Disabled and Queued entries in the shipped Windows resource tables (string IDs 535 and 534).
Verification
System32\schtasks.exe /query /tn opencodex-proxy /fo CSV /nhwith a hidden child and redirected stdout, as in the CLI. The command exited 0 and returned four matching rows (156 bytes). Each state field containedBB E7 BF EB 20 BE C8 20 C7 D4. With Bun 1.4.4 and active localeko-KR, the unchanged productiondecodeWindowsTextBytesdecoded all four as사용 안 함. The v2.100.5 parser returnedunknown. On this PR the same bytes producednot-running, and the checked-stop state adapter needed only the named Scheduler query. A separate shell session on the same machine returned EnglishDisabled. This was a read-only command and byte replay. It does not identify the output from an earlier GUI click.bun --no-env-file --no-install scripts/test.ts --no-env-file --no-install --isolate --parallel=1 tests/windows/windows-checked-stop-live.test.tspassed all 28 tests (106 assertions).bun run typecheckpassed for 2,681 files.bun run structure:checkandgit diff --checkpassed.40e67cc1: a local three-way merge identified one conflict, confined to the two state sets. Keeping the union of both additions passed 13 parser cases, including all four Japanese and all four Korean states. The tests and structure document merge automatically. If either PR lands first, the remaining change should retain both sets of localized words. The registration-read PR fix(windows): query the named task within the stop deadline #8974 merges cleanly with this patch.Checklist
Summary by CodeRabbit
Bug Fixes
Documentation