Skip to content

fix(windows): recognize Korean disabled and queued task states - #8976

Merged
lidge-jun merged 1 commit into
lidge-jun:devfrom
luvs01:codex/windows-ko-task-state
Nov 21, 2026
Merged

lidge-jun merged 1 commit into
lidge-jun:devfrom
luvs01:codex/windows-ko-task-state

Conversation

@luvs01

@luvs01 luvs01 commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Korean Windows can report a disabled Scheduler task as 사용 안 함 and a queued task as 대기. Both words currently produce an unknown state during checked stop. That sends an otherwise conclusive CSV answer to a fresh PowerShell process inside a one-second state-check budget.

Recognize both words in the existing state sets. A disabled task is inactive. A queued task is active because it can still launch. The two strings were independently matched to the English Disabled and Queued entries in the shipped Windows resource tables (string IDs 535 and 534).

Verification

  • Captured the original bytes from a Korean Windows machine using System32\schtasks.exe /query /tn opencodex-proxy /fo CSV /nh with a hidden child and redirected stdout, as in the CLI. The command exited 0 and returned four matching rows (156 bytes). Each state field contained BB E7 BF EB 20 BE C8 20 C7 D4. With Bun 1.4.4 and active locale ko-KR, the unchanged production decodeWindowsTextBytes decoded all four as 사용 안 함. The v2.100.5 parser returned unknown. On this PR the same bytes produced not-running, and the checked-stop state adapter needed only the named Scheduler query. A separate shell session on the same machine returned English Disabled. This was a read-only command and byte replay. It does not identify the output from an earlier GUI click.
  • Ran the v2.100.5 parser on CSV rows containing each Korean word. Both returned unknown. The new regression checks assert the disabled and queued classifications on the current development branch. A read-only Windows measurement of the PowerShell fallback took 3.6 s. These results establish a parsing defect independently of any particular Desktop update attempt.
  • Native Windows x64, Bun 1.4.4. bun --no-env-file --no-install scripts/test.ts --no-env-file --no-install --isolate --parallel=1 tests/windows/windows-checked-stop-live.test.ts passed all 28 tests (106 assertions). bun run typecheck passed for 2,681 files. bun run structure:check and git diff --check passed.
  • Compatibility with the Japanese-state PR #8959 at 40e67cc1: a local three-way merge identified one conflict, confined to the two state sets. Keeping the union of both additions passed 13 parser cases, including all four Japanese and all four Korean states. The tests and structure document merge automatically. If either PR lands first, the remaining change should retain both sets of localized words. The registration-read PR fix(windows): query the named task within the stop deadline #8974 merges cleanly with this patch.
  • Local validation focused on the affected parser and its checked-stop suite on a shared Windows workstation. Broader suite coverage is left to CI.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Bug Fixes

    • Task Scheduler status checks now correctly recognize Korean “queued” and “disabled” labels, while continuing to report unrecognized labels as unknown.
  • Documentation

    • Clarified how queued and disabled Korean statuses are interpreted when determining whether a task is active.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CSV task-state parser now recognizes 대기 as running and 사용 안 함 as not running. The Korean status test and the Part A documentation cover these classifications.

Changes: Korean Task Scheduler status handling

Layer / File(s) Summary
Classify Korean status labels
src/service/windows-checked-stop-live.ts:130-131, tests/windows/windows-checked-stop-live.test.ts:172-176, structure/ops/windows-checked-stop.md:94-96
The parser classifies 대기 as running and 사용 안 함 as not running. The test checks both results. The documentation describes these statuses.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

Merge Risk: Minimal · up to 37d9f

This change makes the Windows task-state parser recognize the Korean "disabled" and "queued" labels instead of returning unknown and falling back to a slower PowerShell query. The change is small and covered by a test, and no merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: the parser and checked-stop state sets now recognize the Korean disabled (사용 안 함) and queued (대기) Windows Scheduler states. The raw summary and objectives both describ…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the parser and checked-stop state sets now recognize the Korean disabled (사용 안 함) and queued (대기) Windows Scheduler states. The raw summary and objectives both describe this same change to the Korean state labels, so the title matches the changeset. It is specific, short, and in a conventional commit format.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d61cca1 and 37d9f42.

Files selected for processing: 3

  • src/service/windows-checked-stop-live.ts
  • structure/ops/windows-checked-stop.md
  • tests/windows/windows-checked-stop-live.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@lidge-jun

Copy link
Copy Markdown
Owner

Maintainer integration into dev (per MAINTAINERS.md; maintainer integration, not an independent approval)

  • Exact head: 37d9f4297de982e68bb5bd6895845afc341534ed
  • Checks on this head: 20 passed, 15 skipped, none pending or failing (Ubuntu PR CI; Windows/macOS are covered by the next dev batch gate).
  • Review threads: none unresolved.
  • Review: gpt-6.1-terra, two rounds, final verdict PASS (reviewed together with fix(windows): recognize Japanese Task Scheduler states #8959, which adds the Japanese words to the same sets and will be rebased onto this).
  • Regression: tests/windows/windows-checked-stop-live.test.ts passes on this head (27 pass, 1 skip) and fails with src/service/windows-checked-stop-live.ts restored from dev (1 fail), run with the Bun 1.4.4 test runner.

@lidge-jun
lidge-jun merged commit c9e9d54 into lidge-jun:dev Nov 21, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants