Repository navigation
fix(windows): recognize Japanese Task Scheduler states - #8959
Conversation
|
Caution Review failedThe pull request is closed. No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. Automatic draft conversion failed. Please convert this pull request to a draft manually until every box above is ticked. Hygiene✅ Deterministic PR hygiene checks passed. |
# Conflicts: # src/service/windows-checked-stop-live.ts
|
Maintainer integration into
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
schtasks /query /fo CSV /nhreports a ready task as準備完了. The checked stop treats that value as unknown and falls back toGet-ScheduledTask, which can exceed the 1 s manager-state budget. On 2.100.5 this causedocx service installto roll back its new Task Scheduler registration.System32/ja-JP/schtasks.exe.mui.準備完了(Ready) and無効(Disabled) prove inactivity.実行中(Running) andキューに登録済み(Queued) remain active because a queued task can start after the check.Related to #8863.
Verification
bun test tests/windows/windows-checked-stop-live.test.ts -t 'ja-JP task state'on the unpatcheddevparser: all four new regression cases reproduced the unwanted PowerShell fallback.bun test tests/windows/windows-checked-stop-live.test.ts tests/windows/windows-checked-stop.test.ts tests/windows/windows-scheduler-install-verification.test.ts: 102 passed, 0 failed on Windows with Bun 1.4.4.bun run typecheckandgit diff --check: passed.ja-JPWindows, read the live CSV through this branch'swindowsCheckedStopLiveDeps().taskState(1000). A ready task returnednot-runningin 842 ms and the running OpenCodex task returnedrunningin 676 ms, both viaschtasksalone. The earlier local package fix also allowedocx service installto complete with/healthzreturning 200.bun run structure:checkandbun run privacy:scan: passed.bun run test:changedwas stopped after 281 s without a completed result. Its output showed a Bun worker waiting on the test run's user lock. The full suite was omitted as disproportionate for a locale-only parser change. The focused Windows suites above cover the changed post-stop status check and the related stop and install checks. Broader import-graph and cross-platform coverage remains with repository CI.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit