Repository navigation
Re-enable builds and tests on Windows - #1454
Merged
Merged
Conversation
Use the ilammy/msvc-dev-cmd@v1 action instead of the hand-crafted code to detect the version fo MSVC
jarzec
commented
Oct 27, 2026
Comment on lines
-77
to
-78
| - name: Prepare compilers - macOS | ||
| if: matrix.os == 'macos-13' |
Contributor
Author
There was a problem hiding this comment.
The MacOS 13 compiler prep was a leftover (effectively dead code) from the clean-up in #1442.
| - name: Prepare compilers - macOS | ||
| if: matrix.os == 'macos-13' | ||
| - name: Prepare compiler - Clang 19 | ||
| if: matrix.os == 'ubuntu-24.04' && startsWith(matrix.compiler, 'clang') |
Contributor
Author
There was a problem hiding this comment.
This excludes the unnecessary Clang installation for the GCC runs.
Comment on lines
+83
to
+87
| - name: Set up MSVC - Windows | ||
| if: startsWith(matrix.os, 'windows') | ||
| uses: ilammy/msvc-dev-cmd@v1 | ||
| with: | ||
| vsversion: ${{ matrix.vs_version }} |
Contributor
Author
There was a problem hiding this comment.
This is a cleaner setup of the MSVC environment with allows the Linux/MacOs step and the Windows step to be combined below.
Comment on lines
-97
to
-100
| "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat" && ^ | ||
| git config --local core.autocrlf false && ^ | ||
| cd regression-tests && ^ | ||
| bash run-tests.sh -c ${{ matrix.compiler }} -s ${{ matrix.cxx_std }} -d ${{ matrix.stdlib }} -l ${{ matrix.os }} |
Contributor
Author
There was a problem hiding this comment.
This is replaced by the use of ilammy/msvc-dev-cmd@v1 above
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows builds and regression test were disabled in #1442 due to a compiler error in MSVC 2022.
The
windows-2025GitHub runners now use MSVC 2026 which does not have the bug.This PR re-enables the builds/tests on Windows using the new available runner setup.
At the same time small improvements were implemented in the
regression-tests.yamlandbuild-cppfront.yamlworkflow filesrun-tests.shscript.