fix(cmd): reject unsupported --output values

pkg/cmd/attempt_get.go

@@ -31,7 +31,7 @@ Examples:
 		RunE: ac.runAttemptGetCmd,
 	}
 
-	ac.cmd.Flags().StringVar(&ac.output, "output", "", "Output format (json)")
+	ac.cmd.Flags().Var(newOutputFormatValue(&ac.output), "output", "Output format (json)")
 
 	return ac
 }

pkg/cmd/attempt_list.go

@@ -43,7 +43,7 @@ Examples:
 	ac.cmd.Flags().IntVar(&ac.limit, "limit", 100, "Limit number of results")
 	ac.cmd.Flags().StringVar(&ac.next, "next", "", "Pagination cursor for next page")
 	ac.cmd.Flags().StringVar(&ac.prev, "prev", "", "Pagination cursor for previous page")
-	ac.cmd.Flags().StringVar(&ac.output, "output", "", "Output format (json)")
+	ac.cmd.Flags().Var(newOutputFormatValue(&ac.output), "output", "Output format (json)")
 
 	return ac
 }

pkg/cmd/connection_create.go

@@ -237,7 +237,7 @@ func newConnectionCreateCmd() *connectionCreateCmd {
 	cc.cmd.Flags().StringVar(&cc.destinationID, "destination-id", "", "Use existing destination by ID")
 
 	// Output flags
-	cc.cmd.Flags().StringVar(&cc.output, "output", "", "Output format (json)")
+	cc.cmd.Flags().Var(newOutputFormatValue(&cc.output), "output", "Output format (json)")
 
 	cc.cmd.MarkFlagRequired("name")
 

pkg/cmd/connection_get.go

@@ -43,7 +43,7 @@ Examples:
 		"cli.arguments": `[{"name":"connection-id-or-name","type":"string","description":"Connection ID or name","required":true}]`,
 	}
 
-	cc.cmd.Flags().StringVar(&cc.output, "output", "", "Output format (json)")
+	cc.cmd.Flags().Var(newOutputFormatValue(&cc.output), "output", "Output format (json)")
 	addIncludeSourceAuthFlagForConnection(cc.cmd, &cc.includeSourceAuth)
 	addIncludeDestinationAuthFlag(cc.cmd, &cc.includeDestinationAuth)
 

pkg/cmd/connection_list.go

@@ -58,7 +58,7 @@ Examples:
 	cc.cmd.Flags().StringVar(&cc.destinationID, "destination-id", "", "Filter by destination ID")
 	cc.cmd.Flags().BoolVar(&cc.disabled, "disabled", false, "Include disabled connections")
 	cc.cmd.Flags().IntVar(&cc.limit, "limit", 100, "Limit number of results")
-	cc.cmd.Flags().StringVar(&cc.output, "output", "", "Output format (json)")
+	cc.cmd.Flags().Var(newOutputFormatValue(&cc.output), "output", "Output format (json)")
 
 	return cc
 }

pkg/cmd/connection_update.go

@@ -73,7 +73,7 @@ Examples:
 	addConnectionRuleFlags(cu.cmd, &cu.connectionRuleFlags)
 
 	// Output
-	cu.cmd.Flags().StringVar(&cu.output, "output", "", "Output format (json)")
+	cu.cmd.Flags().Var(newOutputFormatValue(&cu.output), "output", "Output format (json)")
 
 	return cu
 }

pkg/cmd/connection_upsert.go

@@ -167,7 +167,7 @@ func newConnectionUpsertCmd() *connectionUpsertCmd {
 	cu.cmd.Flags().StringVar(&cu.destinationID, "destination-id", "", "Use existing destination by ID")
 
 	// Output flags
-	cu.cmd.Flags().StringVar(&cu.output, "output", "", "Output format (json)")
+	cu.cmd.Flags().Var(newOutputFormatValue(&cu.output), "output", "Output format (json)")
 
 	// Upsert-specific flags
 	cu.cmd.Flags().BoolVar(&cu.dryRun, "dry-run", false, "Preview changes without applying them")

pkg/cmd/destination_create.go

@@ -64,7 +64,7 @@ Examples:
 	dc.cmd.Flags().StringVar(&dc.CustomSignatureKey, "custom-signature-key", "", "Key/header name for custom signature")
 	addDestinationDeliveryPolicyFlags(dc.cmd, &dc.destinationConfigFlags)
 	dc.cmd.Flags().StringVar(&dc.HTTPMethod, "http-method", "", "HTTP method for HTTP destinations (GET, POST, PUT, PATCH, DELETE)")
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 
 	dc.cmd.MarkFlagRequired("name")
 	dc.cmd.MarkFlagRequired("type")

pkg/cmd/destination_get.go

@@ -36,7 +36,7 @@ Examples:
 		RunE: dc.runDestinationGetCmd,
 	}
 
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 	addIncludeAuthFlagForDestination(dc.cmd, &dc.includeDestAuth)
 
 	return dc

pkg/cmd/destination_list.go

@@ -44,7 +44,7 @@ Examples:
 	dc.cmd.Flags().StringVar(&dc.destType, "type", "", "Filter by destination type (HTTP, CLI, MOCK_API)")
 	dc.cmd.Flags().BoolVar(&dc.disabled, "disabled", false, "Include disabled destinations")
 	dc.cmd.Flags().IntVar(&dc.limit, "limit", 100, "Limit number of results")
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 
 	return dc
 }

pkg/cmd/destination_update.go

@@ -62,7 +62,7 @@ Examples:
 	dc.cmd.Flags().StringVar(&dc.CustomSignatureKey, "custom-signature-key", "", "Key/header name for custom signature")
 	addDestinationDeliveryPolicyFlags(dc.cmd, &dc.destinationConfigFlags)
 	dc.cmd.Flags().StringVar(&dc.HTTPMethod, "http-method", "", "HTTP method for HTTP destinations")
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 
 	return dc
 }

pkg/cmd/destination_upsert.go

@@ -63,7 +63,7 @@ Examples:
 	addDestinationDeliveryPolicyFlags(dc.cmd, &dc.destinationConfigFlags)
 	dc.cmd.Flags().StringVar(&dc.HTTPMethod, "http-method", "", "HTTP method for HTTP destinations")
 	dc.cmd.Flags().BoolVar(&dc.dryRun, "dry-run", false, "Preview changes without applying")
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 
 	return dc
 }

pkg/cmd/event_get.go

@@ -31,7 +31,7 @@ Examples:
 		RunE: ec.runEventGetCmd,
 	}
 
-	ec.cmd.Flags().StringVar(&ec.output, "output", "", "Output format (json)")
+	ec.cmd.Flags().Var(newOutputFormatValue(&ec.output), "output", "Output format (json)")
 
 	return ec
 }

pkg/cmd/event_list.go

@@ -97,7 +97,7 @@ Examples:
 	ec.cmd.Flags().IntVar(&ec.limit, "limit", 100, "Limit number of results")
 	ec.cmd.Flags().StringVar(&ec.next, "next", "", "Pagination cursor for next page")
 	ec.cmd.Flags().StringVar(&ec.prev, "prev", "", "Pagination cursor for previous page")
-	ec.cmd.Flags().StringVar(&ec.output, "output", "", "Output format (json)")
+	ec.cmd.Flags().Var(newOutputFormatValue(&ec.output), "output", "Output format (json)")
 
 	return ec
 }

pkg/cmd/issue_dismiss.go

@@ -34,7 +34,7 @@ Examples:
 	}
 
 	ic.cmd.Flags().BoolVar(&ic.force, "force", false, "Dismiss without confirmation")
-	ic.cmd.Flags().StringVar(&ic.output, "output", "", "Output format (json)")
+	ic.cmd.Flags().Var(newOutputFormatValue(&ic.output), "output", "Output format (json)")
 
 	return ic
 }

pkg/cmd/issue_get.go

@@ -32,7 +32,7 @@ Examples:
 		RunE: ic.runIssueGetCmd,
 	}
 
-	ic.cmd.Flags().StringVar(&ic.output, "output", "", "Output format (json)")
+	ic.cmd.Flags().Var(newOutputFormatValue(&ic.output), "output", "Output format (json)")
 
 	return ic
 }

pkg/cmd/issue_list.go

@@ -53,7 +53,7 @@ Examples:
 	ic.cmd.Flags().IntVar(&ic.limit, "limit", 100, "Limit number of results (max 250)")
 	ic.cmd.Flags().StringVar(&ic.next, "next", "", "Pagination cursor for next page")
 	ic.cmd.Flags().StringVar(&ic.prev, "prev", "", "Pagination cursor for previous page")
-	ic.cmd.Flags().StringVar(&ic.output, "output", "", "Output format (json)")
+	ic.cmd.Flags().Var(newOutputFormatValue(&ic.output), "output", "Output format (json)")
 
 	return ic
 }

pkg/cmd/issue_update.go

@@ -39,7 +39,7 @@ Examples:
 
 	ic.cmd.Flags().StringVar(&ic.status, "status", "", "New issue status (OPENED, IGNORED, ACKNOWLEDGED, RESOLVED) [required]")
 	ic.cmd.MarkFlagRequired("status")
-	ic.cmd.Flags().StringVar(&ic.output, "output", "", "Output format (json)")
+	ic.cmd.Flags().Var(newOutputFormatValue(&ic.output), "output", "Output format (json)")
 
 	return ic
 }

pkg/cmd/metrics.go

@@ -100,7 +100,7 @@ func addMetricsCommonFlags(cmd *cobra.Command, f *metricsCommonFlags, filters ho
 	if filters.IssueID {
 		cmd.Flags().StringVar(&f.issueID, "issue-id", "", "Filter by issue ID (required for per-issue metrics, e.g. when using --dimensions issue_id)")
 	}
-	cmd.Flags().StringVar(&f.output, "output", "", "Output format (json)")
+	cmd.Flags().Var(newOutputFormatValue(&f.output), "output", "Output format (json)")
 	_ = cmd.MarkFlagRequired("start")
 	_ = cmd.MarkFlagRequired("end")
 	// Every metrics endpoint rejects a request without measures, so catch it

pkg/cmd/outpost_attempt.go

@@ -117,7 +117,7 @@ specifically; the filters and results are otherwise the same.`,
 	ac.cmd.Flags().StringVar(&ac.dir, "dir", "", "Sort direction (asc, desc)")
 	ac.cmd.Flags().StringVar(&ac.next, "next", "", "Next page cursor")
 	ac.cmd.Flags().StringVar(&ac.prev, "prev", "", "Previous page cursor")
-	ac.cmd.Flags().StringVar(&ac.output, "output", "", "Output format (json)")
+	ac.cmd.Flags().Var(newOutputFormatValue(&ac.output), "output", "Output format (json)")
 
 	return ac
 }
@@ -215,7 +215,7 @@ func newOutpostAttemptGetCmd() *outpostAttemptGetCmd {
 	ac.cmd.Flags().StringVar(&ac.tenantID, "tenant-id", "", "Tenant the attempt belongs to")
 	ac.cmd.Flags().StringVar(&ac.destinationID, "destination-id", "", "Destination the attempt targeted")
 	ac.cmd.Flags().StringVar(&ac.include, "include", "", "Include related data, comma-separated (event, event.data, response_data, destination)")
-	ac.cmd.Flags().StringVar(&ac.output, "output", "", "Output format (json)")
+	ac.cmd.Flags().Var(newOutputFormatValue(&ac.output), "output", "Output format (json)")
 
 	return ac
 }

pkg/cmd/outpost_config.go

@@ -71,7 +71,7 @@ are omitted unless you ask for one by name.`,
 		},
 	}
 
-	cc.cmd.Flags().StringVar(&cc.output, "output", "", "Output format (json)")
+	cc.cmd.Flags().Var(newOutputFormatValue(&cc.output), "output", "Output format (json)")
 
 	return cc
 }
@@ -169,7 +169,7 @@ which when that happens.`,
 	cc.cmd.Flags().StringArrayVar(&cc.unset, "unset", nil, "Return a key to its default (repeatable)")
 	cc.cmd.Flags().StringVar(&cc.configFile, "config-file", "", "Path to a JSON file of configuration values")
 	cc.cmd.Flags().BoolVar(&cc.dryRun, "dry-run", false, "Show what would change without applying it")
-	cc.cmd.Flags().StringVar(&cc.output, "output", "", "Output format (json)")
+	cc.cmd.Flags().Var(newOutputFormatValue(&cc.output), "output", "Output format (json)")
 
 	return cc
 }

pkg/cmd/outpost_custom_domain.go

@@ -53,7 +53,7 @@ func newOutpostCustomDomainGetCmd() *outpostCustomDomainGetCmd {
   hookdeck outpost config custom-domain get`,
 	}
 
-	cc.cmd.Flags().StringVar(&cc.output, "output", "", "Output format (json)")
+	cc.cmd.Flags().Var(newOutputFormatValue(&cc.output), "output", "Output format (json)")
 
 	return cc
 }
@@ -113,7 +113,7 @@ they have propagated and been verified.`,
 		},
 	}
 
-	cc.cmd.Flags().StringVar(&cc.output, "output", "", "Output format (json)")
+	cc.cmd.Flags().Var(newOutputFormatValue(&cc.output), "output", "Output format (json)")
 
 	return cc
 }

pkg/cmd/outpost_destination_create.go

@@ -56,7 +56,7 @@ Topics default to all ("*") when --topics is omitted.`,
 	}
 
 	dc.cmd.Flags().StringVar(&dc.destType, "type", "", "Destination type (required)")
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 	addOutpostDestinationFieldFlags(dc.cmd, &dc.fields)
 	dc.cmd.MarkFlagRequired("type")
 

pkg/cmd/outpost_destination_disable.go

@@ -37,7 +37,7 @@ The destination and its configuration are kept, so 'enable' resumes delivery.`,
 		},
 	}
 
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 
 	return dc
 }

pkg/cmd/outpost_destination_enable.go

@@ -36,7 +36,7 @@ func newOutpostDestinationEnableCmd(parent *outpostDestinationCmd) *outpostDesti
 		},
 	}
 
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 
 	return dc
 }

pkg/cmd/outpost_destination_get.go

@@ -35,7 +35,7 @@ func newOutpostDestinationGetCmd(parent *outpostDestinationCmd) *outpostDestinat
 		},
 	}
 
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 
 	return dc
 }

pkg/cmd/outpost_destination_list.go

@@ -45,7 +45,7 @@ This endpoint is not paginated: every destination for the tenant is returned.`,
 
 	dc.cmd.Flags().StringVar(&dc.destType, "type", "", "Filter by destination type(s), comma-separated")
 	dc.cmd.Flags().StringVar(&dc.topics, "topics", "", "Filter by topic(s), comma-separated")
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 
 	return dc
 }

pkg/cmd/outpost_destination_type.go

@@ -56,7 +56,7 @@ func newOutpostDestinationTypeListCmd() *outpostDestinationTypeListCmd {
   hookdeck outpost destination-type list`,
 	}
 
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 
 	return dc
 }
@@ -117,7 +117,7 @@ or format the schema constrains it to.`,
 		},
 	}
 
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 
 	return dc
 }

pkg/cmd/outpost_destination_update.go

@@ -53,7 +53,7 @@ so metadata cannot be cleared here.`,
 		},
 	}
 
-	dc.cmd.Flags().StringVar(&dc.output, "output", "", "Output format (json)")
+	dc.cmd.Flags().Var(newOutputFormatValue(&dc.output), "output", "Output format (json)")
 	addOutpostDestinationFieldFlags(dc.cmd, &dc.fields)
 
 	return dc

pkg/cmd/outpost_event_get.go

@@ -43,7 +43,7 @@ func newOutpostEventGetCmd() *outpostEventGetCmd {
 	}
 
 	ec.cmd.Flags().StringVar(&ec.tenantID, "tenant-id", "", "Tenant the event belongs to")
-	ec.cmd.Flags().StringVar(&ec.output, "output", "", "Output format (json)")
+	ec.cmd.Flags().Var(newOutputFormatValue(&ec.output), "output", "Output format (json)")
 
 	return ec
 }

pkg/cmd/outpost_event_list.go

@@ -63,7 +63,7 @@ Filters are combined with AND. Time bounds are ISO 8601 datetimes.`,
 	ec.cmd.Flags().StringVar(&ec.dir, "dir", "", "Sort direction (asc, desc)")
 	ec.cmd.Flags().StringVar(&ec.next, "next", "", "Next page cursor")
 	ec.cmd.Flags().StringVar(&ec.prev, "prev", "", "Previous page cursor")
-	ec.cmd.Flags().StringVar(&ec.output, "output", "", "Output format (json)")
+	ec.cmd.Flags().Var(newOutputFormatValue(&ec.output), "output", "Output format (json)")
 
 	return ec
 }

pkg/cmd/outpost_event_retry.go

@@ -40,7 +40,7 @@ The destination must be enabled and must subscribe to the event's topic.`,
 
 	ec.cmd.Flags().StringVar(&ec.eventID, "event-id", "", "The event to retry (required)")
 	ec.cmd.Flags().StringVar(&ec.destinationID, "destination-id", "", "The destination to deliver to (required)")
-	ec.cmd.Flags().StringVar(&ec.output, "output", "", "Output format (json)")
+	ec.cmd.Flags().Var(newOutputFormatValue(&ec.output), "output", "Output format (json)")
 	ec.cmd.MarkFlagRequired("event-id")
 	ec.cmd.MarkFlagRequired("destination-id")
 

pkg/cmd/outpost_metrics.go

@@ -86,7 +86,7 @@ to bucket the results over time.`, summary, measures, dimensions),
 	mc.cmd.Flags().StringVar(&mc.measures, "measures", "", "Measures to compute, comma-separated (required)")
 	mc.cmd.Flags().StringVar(&mc.dimensions, "dimensions", "", "Dimensions to group by, comma-separated")
 	mc.cmd.Flags().StringArrayVar(&mc.filters, "filter", nil, "Filter as dimension=value (repeatable)")
-	mc.cmd.Flags().StringVar(&mc.output, "output", "", "Output format (json)")
+	mc.cmd.Flags().Var(newOutputFormatValue(&mc.output), "output", "Output format (json)")
 
 	mc.cmd.MarkFlagRequired("start")
 	mc.cmd.MarkFlagRequired("end")

pkg/cmd/outpost_publish.go

@@ -72,7 +72,7 @@ create a Project API key in the Hookdeck dashboard under project settings.`,
 	pc.cmd.Flags().StringVar(&pc.dataFile, "data-file", "", "Path to a JSON file containing the event payload")
 	pc.cmd.Flags().StringArrayVar(&pc.metadata, "metadata", nil, "Metadata as key=value (repeatable)")
 	pc.cmd.Flags().BoolVar(&pc.eligibleForRetry, "eligible-for-retry", true, "Whether failed deliveries should be retried")
-	pc.cmd.Flags().StringVar(&pc.output, "output", "", "Output format (json)")
+	pc.cmd.Flags().Var(newOutputFormatValue(&pc.output), "output", "Output format (json)")
 
 	pc.cmd.MarkFlagRequired("tenant-id")
 	pc.cmd.MarkFlagRequired("topic")

pkg/cmd/outpost_status.go

@@ -34,7 +34,7 @@ being applied.`,
   hookdeck outpost status`,
 	}
 
-	sc.cmd.Flags().StringVar(&sc.output, "output", "", "Output format (json)")
+	sc.cmd.Flags().Var(newOutputFormatValue(&sc.output), "output", "Output format (json)")
 
 	return sc
 }

pkg/cmd/outpost_tenant_get.go

@@ -39,7 +39,7 @@ func newOutpostTenantGetCmd() *outpostTenantGetCmd {
 		},
 	}
 
-	tc.cmd.Flags().StringVar(&tc.output, "output", "", "Output format (json)")
+	tc.cmd.Flags().Var(newOutputFormatValue(&tc.output), "output", "Output format (json)")
 
 	return tc
 }

pkg/cmd/outpost_tenant_list.go

@@ -50,7 +50,7 @@ func newOutpostTenantListCmd() *outpostTenantListCmd {
 	tc.cmd.Flags().StringVar(&tc.dir, "dir", "", "Sort direction (asc, desc)")
 	tc.cmd.Flags().StringVar(&tc.next, "next", "", "Next page cursor")
 	tc.cmd.Flags().StringVar(&tc.prev, "prev", "", "Previous page cursor")
-	tc.cmd.Flags().StringVar(&tc.output, "output", "", "Output format (json)")
+	tc.cmd.Flags().Var(newOutputFormatValue(&tc.output), "output", "Output format (json)")
 
 	return tc
 }

pkg/cmd/outpost_tenant_portal.go

@@ -53,7 +53,7 @@ This requires a portal custom domain to be configured for the project; see
 
 	tc.cmd.Flags().StringVar(&tc.theme, "theme", "", "Portal theme ("+strings.Join(hookdeck.OutpostPortalThemes, ", ")+")")
 	tc.cmd.Flags().BoolVar(&tc.open, "open", false, "Open the portal URL in your browser")
-	tc.cmd.Flags().StringVar(&tc.output, "output", "", "Output format (json)")
+	tc.cmd.Flags().Var(newOutputFormatValue(&tc.output), "output", "Output format (json)")
 
 	return tc
 }

pkg/cmd/outpost_tenant_token.go

@@ -40,7 +40,7 @@ not to be pasted into a shell history or shared.`,
 		},
 	}
 
-	tc.cmd.Flags().StringVar(&tc.output, "output", "", "Output format (json)")
+	tc.cmd.Flags().Var(newOutputFormatValue(&tc.output), "output", "Output format (json)")
 
 	return tc
 }

pkg/cmd/outpost_tenant_upsert.go

@@ -52,7 +52,7 @@ tenant exists will remove metadata it already had.`,
 
 	tc.cmd.Flags().StringArrayVar(&tc.metadata, "metadata", nil, "Metadata as key=value (repeatable)")
 	tc.cmd.Flags().StringVar(&tc.metadataFile, "metadata-file", "", "Path to a JSON file of metadata key/value pairs")
-	tc.cmd.Flags().StringVar(&tc.output, "output", "", "Output format (json)")
+	tc.cmd.Flags().Var(newOutputFormatValue(&tc.output), "output", "Output format (json)")
 
 	return tc
 }