Repository navigation
fix(cmd): reject unsupported --output values - #481
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
Commands with a json-only --output flag silently fell back to the human-readable output for any other value (e.g. yaml) and exited 0. Validate the value when the flag is parsed and name the supported one. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Alex Castillo <alex.castillog33@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #432
Cause: the json-only
--outputflags were plainStringVars and each command only checked== "json", so any other value (yaml,xml, ...) fell through to the human-readable output with exit code 0.Fix: a small
outputFormatValue(pflag.Value) inpkg/cmd/output_flag.gothat accepts""andjsonand returnsunsupported output format "yaml" (supported: json)otherwise, so cobra rejects it at parse time with a non-zero exit. The ~58 json-only--outputregistrations now use it (a mechanical one-line change each).listen --output(interactive/compact/quiet) is a different flag and is untouched. Help text is unchanged apart fromproject list, which saidOutput format: jsonand now matches the others.Test:
TestOutputFormatValue(accept/reject) andTestJSONOutputFlagsRejectUnknownFormat, which walks the whole command tree and checks that every command using the new flag value rejectsyamland acceptsjson.go test ./pkg/cmd/passes,go vetandgofmtclean.This change was prepared with AI assistance (Claude Code).
🤖 Generated with Claude Code