Skip to content

Do not apply #pragma pack(1) to NuqStream::AlignedMatrix and ClusterBuf. #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 15, 2026
Merged

Do not apply #pragma pack(1) to NuqStream::AlignedMatrix and ClusterBuf. #1059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions compression/types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ struct NuqStream {
// smaller size (table amortized over more weights).
static constexpr size_t kGroupSize = 256;

#pragma pack(pop)
// Storage for dynamic programming. There are two matrices; we use separate
// allocations to avoid type punning.
template <class T>
Expand Down Expand Up @@ -200,6 +201,7 @@ struct NuqStream {
AlignedMatrix<float> costs;
AlignedMatrix<int32_t> argmin;
};
#pragma pack(push, 1)

// Returns offset of packed indices from the start of the stream. This matches
// the (padded) total table size because table entries are bytes.
Expand Down
Loading