Repository navigation
Do not apply #pragma pack(1) to NuqStream::AlignedMatrix and ClusterBuf. - #1059
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_999238657
branch
3 times, most recently
from
October 15, 2026 17:53
286c8da to
02380d9
Compare
`#pragma pack(push, 1)` on `NuqStream` currently encloses the nested helper classes `AlignedMatrix` and `ClusterBuf`, which contain `hwy::AlignedFreeUniquePtr<T[]>` (`std::unique_ptr`) members and are allocated as normal working buffers during compression rather than packed into the bitstream. Under `#pragma pack(1)`, `ClusterBuf::argmin` is placed at a non-8-byte-aligned offset on 64-bit targets, triggering `-fsanitize=alignment` on member calls to `std::unique_ptr`. PiperOrigin-RevId: 1000251482
copybara-service
Bot
force-pushed
the
test_999238657
branch
from
October 15, 2026 18:00
02380d9 to
d8e8269
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not apply #pragma pack(1) to NuqStream::AlignedMatrix and ClusterBuf.
#pragma pack(push, 1)onNuqStreamcurrently encloses the nested helper classesAlignedMatrixandClusterBuf, which containhwy::AlignedFreeUniquePtr<T[]>(std::unique_ptr) members and are allocated as normal working buffers during compression rather than packed into the bitstream. Under#pragma pack(1),ClusterBuf::argminis placed at a non-8-byte-aligned offset on 64-bit targets, triggering-fsanitize=alignmenton member calls tostd::unique_ptr.