Repository navigation
test(spring-boot): [Sample Tests 11] Move the Boot 4 sample's tests into the module - #6297
Open
runningcode wants to merge 2 commits into
Open
runningcode wants to merge 2 commits into
runningcode wants to merge 2 commits into
Conversation
📲 Install BuildsAndroid
|
This was referenced Oct 20, 2026
Draft
Draft
Draft
Draft
Draft
This was referenced Oct 20, 2026
Draft
Draft
Open
runningcode
force-pushed
the
no/boot-jakarta-kafka-test
branch
from
October 21, 2026 09:19
0fcb405 to
533c07e
Compare
runningcode
force-pushed
the
no/boot4-integration-test
branch
4 times, most recently
from
October 22, 2026 13:31
9474d15 to
87ed07f
Compare
runningcode
force-pushed
the
no/boot-jakarta-kafka-test
branch
2 times, most recently
from
October 22, 2026 14:02
5d679cd to
d6694c0
Compare
runningcode
force-pushed
the
no/boot4-integration-test
branch
from
October 22, 2026 14:02
87ed07f to
7cc9f29
Compare
runningcode
marked this pull request as ready for review
October 22, 2026 14:50
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
October 22, 2026 14:50
Adds an integrationTest suite to sentry-spring-boot-4 that mirrors the jakarta one and ports the Boot 4 sample's Person, DistributedTracing, Todo, Cache, Metrics and GraphQL tests to it. The sample's tests were copies of the jakarta ones, so the suite is too, adjusted for Spring Boot 4: Jackson 3, the split restclient and resttestclient modules, @AutoConfigureTestRestTemplate, and sentry-spring-7's SentrySpan. The Spring Boot 4 matrix runs the suite against every Boot version it covers. The sample keeps its Kafka test until the next PR. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… Boot 4 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/boot-jakarta-kafka-test
branch
from
October 22, 2026 16:02
d6694c0 to
fbeadbc
Compare
runningcode
force-pushed
the
no/boot4-integration-test
branch
from
October 22, 2026 16:02
7cc9f29 to
8aa2e78
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Sample Tests)
main)📜 Description
Adds an
integrationTestsuite tosentry-spring-boot-4, modeled on the jakarta one. It ports these Boot 4 sample tests and deletes them from the sample:The sample's tests were byte-identical to the jakarta ones; Person differs by 0 lines. So the suite copies the jakarta suite, with these changes for Spring Boot 4:
TestRestTemplate: moved tospring-boot-resttestclient. Boot 4 only provides it when asked, so the base class adds@AutoConfigureTestRestTemplate.RestTemplateBuilder: moved toorg.springframework.boot.restclient.restclientandwebclientstarters, and AOP from theaspectjstarter.tools.jackson.databind, withasStringreplacingasText.SentrySpan: comes fromsentry-spring-7.openmodifiers dropped: this module applieskotlin-spring, which opens Spring-annotated classes anyway.The Spring Boot 4 matrix now runs the suite on every Boot version it covers. The sample keeps
KafkaQueueSystemTestuntil the next PR.After a coverage audit against the sample's tests:
sample_randand deferred-sampling tests check the envelope header's trace ID, the GraphQL task query'sassigneeIdandcreatorIdchecks from test(spring-boot): [Sample Tests 9] Move the Boot 3 GraphQL tests into the module #6295 and a test client built outside the context, as in test(spring-boot): [Sample Tests 7] Move the Boot 3 tracing and HTTP client tests #6293. The base no longer needs@AutoConfigureTestRestTemplate.💡 Motivation and Context
This fans the Spring Boot 3 pilot out to Boot 4. The suite runs 23 tests in about 15s of Gradle time, including Spring startup.
💚 How did you test it?
:sentry-spring-boot-4:checkpasses.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Port the Boot 4 sample's Kafka test, retire the sample from the runner and CI, then do the same for Boot 2.
#skip-changelog