Repository navigation
test(spring-boot): [Sample Tests 10] Move the Boot 3 Kafka test into the module - #6296
Merged
Merged
Conversation
This was referenced Oct 20, 2026
📲 Install BuildsAndroid
|
This was referenced Oct 20, 2026
Draft
Draft
Draft
Draft
Draft
runningcode
force-pushed
the
no/boot-jakarta-graphql-test
branch
2 times, most recently
from
October 21, 2026 11:27
5379114 to
429aa76
Compare
runningcode
force-pushed
the
no/boot-jakarta-kafka-test
branch
2 times, most recently
from
October 22, 2026 12:40
1685dba to
49f143f
Compare
runningcode
force-pushed
the
no/boot-jakarta-graphql-test
branch
2 times, most recently
from
October 22, 2026 13:31
3c3957f to
830cd05
Compare
runningcode
force-pushed
the
no/boot-jakarta-kafka-test
branch
2 times, most recently
from
October 22, 2026 14:02
5d679cd to
d6694c0
Compare
runningcode
marked this pull request as ready for review
October 22, 2026 14:18
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
October 22, 2026 14:18
0xadam-brown
approved these changes
Oct 22, 2026
runningcode
force-pushed
the
no/boot-jakarta-kafka-test
branch
from
October 22, 2026 16:02
d6694c0 to
fbeadbc
Compare
runningcode
force-pushed
the
no/boot-jakarta-graphql-test
branch
from
October 22, 2026 16:02
3269abc to
87dd655
Compare
runningcode
force-pushed
the
no/boot-jakarta-kafka-test
branch
from
October 23, 2026 08:24
fbeadbc to
bedbe69
Compare
runningcode
force-pushed
the
no/boot-jakarta-graphql-test
branch
from
October 23, 2026 08:24
87dd655 to
daf0729
Compare
runningcode
force-pushed
the
no/boot-jakarta-kafka-test
branch
from
October 23, 2026 08:58
bedbe69 to
a60ceb3
Compare
runningcode
force-pushed
the
no/boot-jakarta-graphql-test
branch
2 times, most recently
from
October 23, 2026 09:35
9882327 to
d003698
Compare
runningcode
force-pushed
the
no/boot-jakarta-kafka-test
branch
from
October 23, 2026 09:35
a60ceb3 to
accabe3
Compare
Ports the jakarta sample's KafkaQueueSystemTest to the integrationTest suite with an embedded KRaft broker, so no Docker is needed. The five sample tests become two that keep every assertion: the publishing request's queue.publish span, and a queue.process transaction that continues the producer's trace. Both check the messaging attributes. The broker is declared with @embeddedkafka on the shared base class so it belongs to the one application context: it starts before the app's listener connects and stops after it. The jakarta sample has no system tests left, so it comes off the system-test runner, the backend workflow and the Spring Boot 3 matrix, which keeps running the module's integration suites. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/boot-jakarta-kafka-test
branch
from
October 23, 2026 10:27
accabe3 to
a18850d
Compare
runningcode
enabled auto-merge (squash)
October 23, 2026 10:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Sample Tests)
main)📜 Description
Ports the jakarta sample's
KafkaQueueSystemTestto theintegrationTestsuite insentry-spring-boot-jakarta. That was the sample's last system test, so this PR also takes the sample off the system-test runner and CI.Kafka tests. The suite gets an embedded KRaft broker from
spring-kafka-test. It runs in the test JVM, so no Docker or Redpanda is needed. The sample's five tests become two that keep every assertion:queue.publishspan.queue.processtransaction continues the producer's trace.messaging.system=kafkaandmessaging.destination.name=sentry-topic.Each message is tied to its producer transaction by the request's query string, and to its consumer transaction by trace ID. The tests still pass on a shared mock server even if a late envelope arrives from another test.
Broker lifecycle.
@EmbeddedKafkaon the shared base class makes the broker part of the single application context. It starts before the app's listener connects and stops after it. An earlier version started the broker by hand, and that leftKafkaStorageExceptionnoise at shutdown.Catalog.
spring-kafka3 and the newspring-kafka-testnow share aspringKafka3version, so the broker always matches the client.Jakarta sample retired from system tests:
systemTesttask, theio.sentry.systemtestplugin, its test dependencies and its last test files. The app code stays as an example.sentry-samples-spring-boot.Without these removals, the sample's
systemTestwould have no tests left. Gradle fails a test task that matches none, so the blocking matrix would break.💡 Motivation and Context
This finishes the Spring Boot 3 pilot: everything the jakarta sample's system tests checked now runs in-module.
The suites aren't part of
check; the Spring Boot 3 matrix runs them.💚 How did you test it?
:sentry-spring-boot-jakarta:checkpasses.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog