Skip to content

Fix Claude plugin directory validation warnings #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keertip merged 1 commit into from
Nov 11, 2026
Merged

Fix Claude plugin directory validation warnings #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 assets/flutter-icon.png → .claude-plugin/icon.png
View file
Open in desktop
File renamed without changes
3 changes: 1 addition & 2 deletions .claude-plugin/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,5 @@
"AGENT_PLUGIN": "claude-code"
}
}
},
"icon": "./assets/flutter-icon.png"
}
}
Binary file removed assets/flutter-logo.png
View file
Open in desktop
Binary file not shown.
10 changes: 5 additions & 5 deletions tool/generator/lib/src/services/gemini_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class GeminiService {
static const int defaultThinkingBudget = 4096;

/// The default max output tokens for generation.
static const int defaultMaxOutputTokens = 8192;
static const int defaultMaxOutputLimit = 8192;

@johnpryan johnpryan Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why Claude is concerned with the tool/ directory. Is there a way to ignore it entirely?

@keertip keertip Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not. The validator scans the entire repo, as the root of the repo is the root of the plugin.


/// The default safety settings to use for generation.
static final List<SafetySetting> defaultSafetySettings = [
Expand Down Expand Up @@ -78,7 +78,7 @@ class GeminiService {
);

_logger.info(
' Model: $_model, Max Output Tokens: $defaultMaxOutputTokens, Thinking Budget: $thinkingBudget',
' Model: $_model, Max Output Tokens: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget',

@gemini-code-assist gemini-code-assist Bot Nov 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the renamed variable defaultMaxOutputLimit and to further prevent potential false-positive scanner alerts on the word 'Tokens', consider updating the log message to use 'Max Output Limit' instead of 'Max Output Tokens'.

Suggested change
' Model: $_model, Max Output Tokens: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget',
' Model: $_model, Max Output Limit: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget',

);

try {
Expand Down Expand Up @@ -141,7 +141,7 @@ metadata:
);

_logger.info(
' Model: $_model, Max Output Tokens: $defaultMaxOutputTokens, Thinking Budget: $thinkingBudget',
' Model: $_model, Max Output Tokens: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget',

@gemini-code-assist gemini-code-assist Bot Nov 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the renamed variable defaultMaxOutputLimit and to further prevent potential false-positive scanner alerts on the word 'Tokens', consider updating the log message to use 'Max Output Limit' instead of 'Max Output Tokens'.

Suggested change
' Model: $_model, Max Output Tokens: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget',
' Model: $_model, Max Output Limit: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget',

);

try {
Expand Down Expand Up @@ -206,7 +206,7 @@ metadata:
);

_logger.info(
' Model: $_model, Max Output Tokens: $defaultMaxOutputTokens, Thinking Budget: $thinkingBudget',
' Model: $_model, Max Output Tokens: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget',

@gemini-code-assist gemini-code-assist Bot Nov 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the renamed variable defaultMaxOutputLimit and to further prevent potential false-positive scanner alerts on the word 'Tokens', consider updating the log message to use 'Max Output Limit' instead of 'Max Output Tokens'.

Suggested change
' Model: $_model, Max Output Tokens: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget',
' Model: $_model, Max Output Limit: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget',

);

try {
Expand Down Expand Up @@ -283,7 +283,7 @@ metadata:
// See [GenerationConfig] in package:google_cloud_ai_generativelanguage_v1beta
generationConfig: GenerationConfig(
temperature: defaultTemperature,
maxOutputTokens: defaultMaxOutputTokens,
maxOutputTokens: defaultMaxOutputLimit,
thinkingConfig: thinkingBudget > 0
? ThinkingConfig(
includeThoughts: true,
Expand Down