Repository navigation
Fix Claude plugin directory validation warnings - #265
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the icon configuration from the Claude plugin settings and renames the defaultMaxOutputTokens constant to defaultMaxOutputLimit in the Gemini service, updating its references. The review feedback suggests updating the corresponding log messages to use 'Max Output Limit' instead of 'Max Output Tokens' for consistency and to prevent potential false-positive scanner alerts.
|
|
||
| _logger.info( | ||
| ' Model: $_model, Max Output Tokens: $defaultMaxOutputTokens, Thinking Budget: $thinkingBudget', | ||
| ' Model: $_model, Max Output Tokens: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget', |
There was a problem hiding this comment.
To maintain consistency with the renamed variable defaultMaxOutputLimit and to further prevent potential false-positive scanner alerts on the word 'Tokens', consider updating the log message to use 'Max Output Limit' instead of 'Max Output Tokens'.
| ' Model: $_model, Max Output Tokens: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget', | |
| ' Model: $_model, Max Output Limit: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget', |
|
|
||
| _logger.info( | ||
| ' Model: $_model, Max Output Tokens: $defaultMaxOutputTokens, Thinking Budget: $thinkingBudget', | ||
| ' Model: $_model, Max Output Tokens: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget', |
There was a problem hiding this comment.
To maintain consistency with the renamed variable defaultMaxOutputLimit and to further prevent potential false-positive scanner alerts on the word 'Tokens', consider updating the log message to use 'Max Output Limit' instead of 'Max Output Tokens'.
| ' Model: $_model, Max Output Tokens: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget', | |
| ' Model: $_model, Max Output Limit: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget', |
|
|
||
| _logger.info( | ||
| ' Model: $_model, Max Output Tokens: $defaultMaxOutputTokens, Thinking Budget: $thinkingBudget', | ||
| ' Model: $_model, Max Output Tokens: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget', |
There was a problem hiding this comment.
To maintain consistency with the renamed variable defaultMaxOutputLimit and to further prevent potential false-positive scanner alerts on the word 'Tokens', consider updating the log message to use 'Max Output Limit' instead of 'Max Output Tokens'.
| ' Model: $_model, Max Output Tokens: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget', | |
| ' Model: $_model, Max Output Limit: $defaultMaxOutputLimit, Thinking Budget: $thinkingBudget', |
|
|
||
| /// The default max output tokens for generation. | ||
| static const int defaultMaxOutputTokens = 8192; | ||
| static const int defaultMaxOutputLimit = 8192; |
There was a problem hiding this comment.
I'm not sure why Claude is concerned with the tool/ directory. Is there a way to ignore it entirely?
There was a problem hiding this comment.
Unfortunately not. The validator scans the entire repo, as the root of the repo is the root of the plugin.
Resolves validation warnings and false-positive policy holds reported by the Claude plugin directory scanner:
assets/flutter-icon.pngto.claude-plugin/icon.pngand removes the"icon"key from.claude-plugin/plugin.jsonso the directory picks up the icon by convention without triggeringUNKNOWN_KEY_CROSS_TOOL.assets/flutter-logo.png, which triggeredUNREAD_ASSET_REFERENCEDfindings acrosstool/.defaultMaxOutputTokenstodefaultMaxOutputLimitintool/generator/lib/src/services/gemini_service.dartso the directory scanner does not mistake the identifier for a credential token (MCP_FORWARDS_CREDENTIAL_ENV).