Repository navigation
Upgrade Rails to 8.1 - #47
Closed
etagwerker wants to merge 5 commits into
Closed
etagwerker wants to merge 5 commits into
etagwerker wants to merge 5 commits into
Conversation
ffi 1.15.5 does not compile on current macOS SDKs. Rails 7.0.10 is the latest patch of the 7.0 series, the starting point for the 8.1 upgrade. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Bump rails to ~> 7.1.0 (7.1.6) - cache_classes -> enable_reloading - test env: show_exceptions = :none, rspec fixture_paths - rspec-rails 7.1, ombu_labs-auth 1.2 (devise 5, drops the secrets deprecation) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Bump rails to ~> 7.2.0 (7.2.3) - :unprocessable_entity -> :unprocessable_content (Rack 3.1 deprecation) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Bump rails to ~> 8.0.0 (8.0.5.2) - Set to_time_preserves_timezone to :zone (8.0 deprecates true) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Bump rails to ~> 8.1.0 (8.1.4.1) - database.yml: pool -> max_connections - Drop to_time_preserves_timezone override (deprecated in 8.1) - CI: install bundler 2.5.22 to match Gemfile.lock BUNDLED WITH Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Rails from 7.0.4 to 8.1.4.1. I followed the rails-upgrade skill hop by hop (7.0.10, 7.1, 7.2, 8.0, 8.1), with one commit per hop so each step is easy to review or bisect. The suite was green (83 examples, 0 failures) after every commit.
Commits
cache_classesbecameenable_reloading, test envshow_exceptions = :none,fixture_pathsinrails_helper. rspec-rails goes to 7.1 (5.1 doesn't work with 7.1).ombu_labs-authgoes to 1.2.0, which allows Devise 5 and gets rid of theRails.application.secretsdeprecation that would have broken on 7.2.:unprocessable_entitybecame:unprocessable_content(Rack 3.1 deprecation).to_time_preserves_timezone = :zone.poolbecamemax_connectionsindatabase.yml, dropped theto_time_preserves_timezoneoverride (deprecated in 8.1), and CI now installs bundler 2.5.22 to match the lockfile.Things worth a close look
ombu_labs-auth1.0.0 to 1.2.0 pulls in Devise 4.8 to 5.0 and a few new runtime dependencies (omniauth-google-oauth2, pluscapybara,selenium-webdriverandpuma). Google login is env-var driven, so GitHub login should be unaffected, but please try signing in on a review app before merging.Gemfile.lock, so it follows along.load_defaultsis still 7.0. I left that for follow-up PRs. The rails-load-defaults skill walks through one config per commit with testing in between, which doesn't fit in this PR.force_ssl/assume_sslare still commented out in production. Rails 8.0 and 8.1 both flag this as optional. Heroku terminates SSL for us, but it's worth a separate look.Verification
bundle exec rspec: 83 examples, 0 failures on 8.1.4.1bin/rails zeitwerk:check: all goodDEPRECATION WARNINGlines in the suite output🤖 Generated with Claude Code