Repository navigation
Upgrade Rails to 8.0, dual-boot with 8.1 - #48
Merged
Merged
Conversation
ffi 1.15.5 does not compile on current macOS SDKs. Rails 7.0.10 is the latest patch of the 7.0 series, the starting point for the 8.1 upgrade. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Backward-compatible gem bumps on Rails 7.0 so the next hops don't need version branching for them. ombu_labs-auth 1.2 allows Devise 5, which drops the Rails.application.secrets usage that Rails 7.2 removes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- next_rails moved to the root of the Gemfile, bumped to 1.7 (NextRails.next?) - Gemfile.next (symlink) and Gemfile.next.lock - CI runs the suite against both Gemfile and Gemfile.next - Two-sided 7.1 changes branch on NextRails.next?: cache_classes -> enable_reloading, show_exceptions = :none Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Gemfile: 7.1 current, 7.2 next - Collapse the 7.1 NextRails.next? branches (next side wins) - fixture_path -> fixture_paths (works on 7.1 and 7.2) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Gemfile: 7.2 current, 8.0 next - Set to_time_preserves_timezone to :zone (works on 7.2 and 8.0) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Gemfile: 8.0 current, 8.1 next - database.yml: pool -> max_connections on 8.1 (two-sided, branches on NextRails.next?) - to_time_preserves_timezone override only on 8.0 (8.1 deprecates it) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Gemfile: rails ~> 8.1.0 (8.1.4.1) on both sides - Collapse the 8.1 NextRails.next? branches (next side wins) The dual-boot scaffolding (next? helper, Gemfile.next, CI matrix) is still in place. The upgrade-cleanup skill removes it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Back to Rails 8.0 as current with 8.1 as the next (dual-boot) version, so the PR ships 8.0 and keeps 8.1 ready to flip. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The next lockfile still pointed at the GitHub fork after sitemap-parser moved to rubygems.org. Re-derived it from Gemfile.lock and re-resolved Rails 8.1. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
etagwerker
marked this pull request as ready for review
November 22, 2026 02:32
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Rails from 7.0.4 to 8.0.5.2 and leaves the app dual-booting with 8.1.4.1. It goes one hop at a time (7.0.10, 7.1, 7.2, 8.0) using the rails-upgrade skill and
next_rails. This replaces #47, which bumped each hop directly without dual-boot.Gemfileruns 8.0 andGemfile.nextruns 8.1. The first two commits are green on 7.0. Every commit from the dual-boot setup on is green on both Gemfiles (83 examples, 0 failures), so each one is a safe stopping point.Merging this ships 8.0. Flipping to 8.1 is a follow-up that swaps the lockfiles and collapses the
NextRails.next?branches. It's already been done and tested on this branch (see 411b192, reverted in 2a2c287).How the commits are laid out
ombu_labs-auth1.2 allows Devise 5, which gets rid of theRails.application.secretsusage that 7.2 removes.next_railsmoves to the Gemfile root (1.2.1 to 1.7, sinceNextRails.next?doesn't exist in 1.2), plus thenext?helper,Gemfile.nextand its lockfile, and a CI matrix over both Gemfiles.Gemfile.next.lockwith it.Each promotion collapses the previous hop's
NextRails.next?branches (next side wins), so noelsebranch is left running on a newer Rails.Changes that needed
NextRails.next?(two-sided)pool:andmax_connections:indatabase.yml(8.1)to_time_preserves_timezone = :zoneis needed on 8.0 and deprecated on 8.1 (8.1)The 7.1 branches (
cache_classes,show_exceptions) were already collapsed when 7.1 was promoted.Changes that were plain migrations (work on both sides)
fixture_pathtofixture_paths(7.1 and 7.2)to_time_preserves_timezone = :zone(7.2 and 8.0)Things worth a close look
ombu_labs-auth1.0.0 to 1.2.0 pulls in Devise 4.8 to 5.0 and a few new runtime dependencies (omniauth-google-oauth2, pluscapybara,selenium-webdriverandpuma). Google login is env-var driven, so GitHub login should be unaffected, but please try signing in on a review app.test-rails-currentis nowTest (Gemfile)andTest (Gemfile.next). If branch protection requires the old check name, it needs updating.Gemfile.lock, so it follows along.load_defaultsis still 7.0. I left that for follow-up PRs, one config at a time.force_ssl/assume_sslare still commented out in production. Rails 8.0 and 8.1 both flag this as optional. Worth a separate look.Verification
bundle exec rspeconGemfile(8.0.5.2) andGemfile.next(8.1.4.1): 83 examples, 0 failures, noDEPRECATION WARNINGlines🤖 Generated with Claude Code