Skip to content

Skip heredoc/nowdoc bodies when spacing attribute concat in blink #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 30, 2026
Merged

Skip heredoc/nowdoc bodies when spacing attribute concat in blink #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions blink/internal/fixer/rules/concat_space.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,13 @@ func spaceAttributeConcat(value string, none bool) (string, bool) {
}
continue
}
if c == '<' && strings.HasPrefix(value[i:], "<<<") {
if end := heredocEnd(value, i); end > i {
b = append(b, value[i:end]...)
i = end - 1
continue
}
}
if c == '\'' || c == '"' {
quote = c
b = append(b, c)
Expand Down
1 change: 1 addition & 0 deletions blink/internal/fixer/rules/concat_space_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ func TestConcatSpaceConfigCases(t *testing.T) {
{"float literal in attribute left alone", ConcatSpace{}, "<?php #[X(1.5)]\nclass C {}", "<?php #[X(1.5)]\nclass C {}"},
{"spread in attribute left alone", ConcatSpace{}, "<?php #[X(...$a)]\nclass C {}", "<?php #[X(...$a)]\nclass C {}"},
{"scope resolution in attribute left alone", ConcatSpace{}, "<?php #[X(self::A.'b')]\nclass C {}", "<?php #[X(self::A . 'b')]\nclass C {}"},
{"dot inside attribute heredoc left alone", ConcatSpace{}, "<?php #[X(help: <<<'TXT'\n%command.name% runs.\nTXT, __DIR__.'/x')]\nclass C {}", "<?php #[X(help: <<<'TXT'\n%command.name% runs.\nTXT, __DIR__ . '/x')]\nclass C {}"},
}
for _, c := range cases {
got, _ := apply(t, c.rule, c.src)
Expand Down
Loading