Repository navigation
Skip heredoc/nowdoc bodies when spacing attribute concat in blink - #244
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #240 (merged) spaces the
.concat operator inside#[...]attributes, butits char-scanner only skips
'...'/"..."strings, not heredoc/nowdoc bodies.A nowdoc inside an attribute (e.g.
help: <<<'TXT' ... TXT) therefore had thedots in its body spaced -
%command.name%became%command . name%andsentence periods gained a space - which ECS never does. This regressed mautic
parity from 0% to 0.58% (26 files, over the 0.05% gate).
Fix: in spaceAttributeConcat, detect a
<<<heredoc/nowdoc start and skip itswhole body via the existing heredocEnd helper, so dots inside are left alone.
Real concat in the same attribute is still spaced.