Repository navigation
Space concat operator inside PHP attributes in blink ConcatSpace - #240
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blink lexes an entire
#[...]attribute as a single opaque Comment token, sotoken-walking fixers never see the
.concat operator inside. ConcatSpacetherefore left attribute concatenations unchanged while PHP ECS spaces them.
This mirrors the existing
collapseAttributeArrowSpacingprecedent inbinary_operator_spaces.go: after the normal token pass, rewrite the attribute
token text to force a single space around each top-level
.(spacing: one) orremove it (spacing: none).
The char scan skips dots inside quoted strings,
...spreads and floatliterals (1.5, .5, 1.), and
nonemode keeps a space that guards a number.Fixes laravel parity for tests/Foundation/FoundationDocsCommandTest.php and
tests/Integration/Foundation/Console/AboutCommandTest.php.