Repository navigation
Feature/60596 missing browser globals - #6
Merged
Merged
Conversation
The filter callback never returned a value and Object.keys() produced numeric keys, so no browser globals were registered and no-undef flagged window, document, etc. Destructure AudioWorkletGlobalScope out of the browser globals and spread the rest Ref #60596
eslint-plugin-vue 10 declares vue-eslint-parser as a peer dependency, so a clean install failed to load the Vue config. Add it as a direct dependency. Ref #60595
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the browser-global configuration and Vue parser dependency updates.
No open issues 🎉
What changed in this PR
This PR updates the shared ESLint configurations to restore browser globals and explicitly include the Vue parser dependency.
Changes:
- Replaces the ineffective browser-global filtering with object destructuring and spreading, excluding
AudioWorkletGlobalScope. - Adds
vue-eslint-parseras a direct dependency of the Vue configuration package.
| File | Description |
|---|---|
packages/eslint-config-vue/package.json |
Adds the Vue parser dependency. |
packages/eslint-config-base/index.js |
Corrects browser-global inclusion while excluding AudioWorkletGlobalScope. |
Review effort: Balanced
Gandhi11
approved these changes
Nov 3, 2026
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes targeted improvements to the ESLint configuration packages, focusing on global variable handling and dependency completeness.
ESLint global variable handling:
packages/eslint-config-base/index.js: Refactored how browser globals are included by destructuringAudioWorkletGlobalScopeout ofesLintGlobals.browserand spreading the remaining globals, ensuringAudioWorkletGlobalScopeis excluded from the configuration.Dependency updates:
packages/eslint-config-vue/package.json: Addedvue-eslint-parseras a dependency to ensure proper parsing of Vue files during linting.