Skip to content

Feature/60596 missing browser globals - #6

Merged
rmenu-pro merged 2 commits into
mainfrom
feature/60596-missing-browser-globals
Nov 3, 2026
Merged

rmenu-pro merged 2 commits into
mainfrom
feature/60596-missing-browser-globals

Conversation

@rmenu-pro

Copy link
Copy Markdown
Contributor

This pull request makes targeted improvements to the ESLint configuration packages, focusing on global variable handling and dependency completeness.

ESLint global variable handling:

  • packages/eslint-config-base/index.js: Refactored how browser globals are included by destructuring AudioWorkletGlobalScope out of esLintGlobals.browser and spreading the remaining globals, ensuring AudioWorkletGlobalScope is excluded from the configuration.

Dependency updates:

The filter callback never returned a value and Object.keys() produced numeric keys, so no browser globals were registered and no-undef flagged window, document, etc. Destructure AudioWorkletGlobalScope out of the browser globals and spread the rest

Ref #60596
eslint-plugin-vue 10 declares vue-eslint-parser as a peer dependency, so a clean install failed to load the Vue config. Add it as a direct dependency.

Ref #60595

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the browser-global configuration and Vue parser dependency updates.

No open issues 🎉

What changed in this PR

This PR updates the shared ESLint configurations to restore browser globals and explicitly include the Vue parser dependency.

Changes:

  • Replaces the ineffective browser-global filtering with object destructuring and spreading, excluding AudioWorkletGlobalScope.
  • Adds vue-eslint-parser as a direct dependency of the Vue configuration package.
File Description
packages/​eslint-config-vue/​package.json Adds the Vue parser dependency.
packages/​eslint-config-base/​index.js Corrects browser-global inclusion while excluding AudioWorkletGlobalScope.

Review effort: Balanced

@rmenu-pro
rmenu-pro requested a review from Gandhi11 November 3, 2026 14:53
@rmenu-pro
rmenu-pro merged commit 155e205 into main Nov 3, 2026
5 checks passed
@rmenu-pro
rmenu-pro deleted the feature/60596-missing-browser-globals branch November 3, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants