Repository navigation
feat(stylelint-config)!: support stylelint 17 (#60804) - #7
Merged
Merged
Conversation
- Update stylelint-config-standard-scss to ^17.0.0 (stylelint-config-standard 40, stylelint-config-recommended 18). - Require stylelint ^17.0.0 and declare postcss ^8.4.29 as peer dependencies. - Require Node.js >=20.19.0, as stylelint 17 does. BREAKING CHANGE: stylelint 16 is no longer supported, postcss must be installed by the project and the upstream configs enable new rules (color-function-alias-notation, lightness-notation, property-no-deprecated, block-no-redundant-nested-style-rules, etc.). Refs #60804
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Publishes
@exolnet/stylelint-config7.0.0, compatible with stylelint 17. Projects already on stylelint 17 (e.g. Control Panel) currently getYN0060/YN0086peer dependency warnings onyarn installwith 6.0.2.stylelint-config-standard-scss^12.0.0 → ^17.0.0 (bringsstylelint-config-standard40 andstylelint-config-recommended18).stylelint^17.0.0, andpostcss^8.4.29 (needed bypostcss-scss).engines.node>=20.19.0, matching stylelint 17.stylelintandpostcsspeers.Our own rule overrides are unchanged. The
vue-eslint-parseritem from the task was already handled in #6 (@exolnet/eslint-config-vue7.1.0).Ref: https://redmine.exolnet.com/issues/60804
Type of change
Breaking changes to mention in the 7.0.0 release notes:
stylelint^17 andpostcss.color-function-alias-notation(rgba→rgb),lightness-notation,property-no-deprecated,at-rule-no-deprecated,block-no-redundant-nested-style-rules,container-name-pattern,layer-name-pattern. Most are autofixable with--fix.How Has This Been Tested?
stylelint@17andpostcssin a clean project: no peer dependency problems (npm ls).stylelinton a sample SCSS file (@use, variables, mixins, nesting,:before, PascalCase class): config loads, our overrides still apply, only the expected new color rules report.Environment:
Checklist: