Repository navigation
Conversation
🦋 Changeset detectedLatest commit: f8b3575 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ff4fbde to
9d14560
Compare
|
9d14560 to
39858b5
Compare
39858b5 to
348b6ac
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Published guidance contains generation and interaction defects, and maintenance records do not match the shipped skill.
10 open issues
Synchronize skill inventory and review records · New Add displayAs setting to the column schema · New Exclude primary column from status columns · New Support object-based filtering configurations · New Count selected IDs only among displayed items · New Declare hasActiveFilters for count-only grids · New Align bulk action identifiers with DT-9 · New Remove invalid JSX comments from opening tags · New Stop checkbox clicks from triggering row navigation · New Prevent popup menu trigger from activating the row · New
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Packages a consumer-facing DataGrid skill with Juno’s UI components and adds Intent maintenance infrastructure.
Changes:
- Adds DataGrid generation rules, canonical fragments, and component references.
- Includes the skill in package publishing and adds discovery metadata.
- Adds Intent tooling, CI workflows, and maintenance records.
| File | Description |
|---|---|
pnpm-lock.yaml |
Records Intent and dependency resolution changes. |
packages/ui-components/skills/build-data-grids/SKILL.md |
Defines DataGrid generation rules. |
packages/ui-components/skills/build-data-grids/references/fragment-library.md |
Provides canonical component fragments. |
packages/ui-components/skills/build-data-grids/references/component-props.md |
Documents DataGrid props and structural classes. |
packages/ui-components/package.json |
Includes the skill in published files and discovery keywords. |
package.json |
Adds Intent tooling. |
AGENTS.md |
Documents skill maintenance procedures. |
.tool-versions |
Pins Node.js and pnpm versions. |
.intent/review-state.json |
Records skill review metadata. |
.github/workflows/check-skills.yml |
Adds skill validation and review automation. |
.changeset/ui-components-ship-data-grid-skill.md |
Requests a patch release for skill distribution. |
_artifacts/skill_tree.yaml |
Defines the skill registry and source mappings. |
_artifacts/skill_spec.md |
Records skill scope, decisions, and checks. |
_artifacts/domain_map.yaml |
Maps skills to developer tasks. |
Review effort: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
Published fragments contain unsupported Status usage and invalid JSX that would produce broken consumer implementations.
9 open issues
Fix invalid quoted placeholder JSX · New Use supported Status props for generated state fragments · New Prevent popup menu trigger from activating the row Stop checkbox clicks from triggering row navigation Remove invalid JSX comments from opening tags Count selected IDs only among displayed items Support object-based filtering configurations Exclude primary column from status columns Add displayAs setting to the column schema
3 resolved since last review
1 file not reviewed
pnpm-lock.yaml: Generated file
Review effort: Balanced
Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com> Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
…2101) * feat(ui): restructure DataGrid skills around a shared DataGridSpec Signed-off-by: Franz Heidl <franz.heidl@sap.com> * chore(ui): prune dropped datagrid-filters-toolbar from review-state Signed-off-by: Franz Heidl <franz.heidl@sap.com> --------- Signed-off-by: Franz Heidl <franz.heidl@sap.com> Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
…kflow pin Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
eb116b7 to
66dfb58
Compare
…library Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
| To consume them in your project, add Intent as a dev dependency and run its setup, then | ||
| load the skill that matches your task: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
I would skip this bash code block and just add a reference to the:
Check Quick Start for Consumers
to avoid drifting...


Summary
Sets up TanStack Intent for the
@cloudoperators/juno-ui-componentspackage and ships the first skill batch: a set of agent "skills" for the Juno DataGrid. This gives consumers and coding agents authoritative, versioned guidance for building and validating DataGrids, published together with the npm package.Changes Made
AGENTS.mdprocedure,_artifacts/planning records, and.intent/review state).packages/ui-components/skills/:datagrid(owns the shared DataGridSpec),datagrid-build, anddatagrid-validate, plus their references.files,tanstack-intentkeyword).patchbump for@cloudoperators/juno-ui-components.Related Issues
Screenshots (if applicable)
N/A. No runtime/UI changes; this adds authoring/agent guidance and tooling only.
Testing Instructions
pnpm ipnpm exec intent maintainer check --base origin/main(validates the skills andrecorded reviews, should pass with 0 pending items)
Checklist
PR Manifesto
Review the PR Manifesto for best practises.