Repository navigation
feat(ci): add skills check - #2100
Merged
Merged
Conversation
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
|
Contributor
|
taymoor89
pushed a commit
that referenced
this pull request
Oct 21, 2026
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com> Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
taymoor89
pushed a commit
that referenced
this pull request
Oct 21, 2026
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com> Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adapts the TanStack Intent-generated
check-skills.ymlworkflow for the Juno monorepo. The workflow validates that skills stay in sync with component source on every relevant PR, without running on unrelated changes.Changes Made
pathscovering only skill-relevant files (packages/ui-components/skills/**,packages/ui-components/src/components/**,_artifacts/**,.intent/**)releasetrigger and thereview/publish-reviewjobs — these are post-publish checks that don't apply here since we release via changesets from a clean main, and thevalidatejob on PRs already guarantees skills are consistent before anything merges.nvmrcvia asetupjob and passes it to the reusable workflow (which only acceptsnode-versionas a plain string, not a file path).tool-versionsas the version source (being removed)The three jobs from the original template and their roles:
validatereviewpublish-reviewreviewreviewandpublish-reviewwere considered for wiring into the changeset release workflow but ruled out — the edge cases they cover (force merges, validate bugs, build-step divergence) are not applicable to this repo, andvalidateon PRs is sufficient.Related Issues
Testing Instructions
packages/ui-components/src/components/**orpackages/ui-components/skills/**and verify theCheck Skillsworkflow triggersChecklist