Skip to content

feat(ci): add skills check - #2100

Merged
ArtieReus merged 1 commit into
2094-setup-tanstack-intentfrom
artie-inetnt-ci-check
Oct 20, 2026
Merged

ArtieReus merged 1 commit into
2094-setup-tanstack-intentfrom
artie-inetnt-ci-check

Conversation

@ArtieReus

Copy link
Copy Markdown
Collaborator

Summary

Adapts the TanStack Intent-generated check-skills.yml workflow for the Juno monorepo. The workflow validates that skills stay in sync with component source on every relevant PR, without running on unrelated changes.

Changes Made

  • Scoped the workflow trigger to paths covering only skill-relevant files (packages/ui-components/skills/**, packages/ui-components/src/components/**, _artifacts/**, .intent/**)
  • Removed the release trigger and the review / publish-review jobs — these are post-publish checks that don't apply here since we release via changesets from a clean main, and the validate job on PRs already guarantees skills are consistent before anything merges
  • Reads Node.js version from .nvmrc via a setup job and passes it to the reusable workflow (which only accepts node-version as a plain string, not a file path)
  • Dropped .tool-versions as the version source (being removed)

The three jobs from the original template and their roles:

Job Runs against Purpose
validate local source tree (on PR) catches drift before merge
review published npm package catches drift after release, from a consumer's perspective
publish-review output of review posts the review report as a PR comment (delivery only, no new analysis)

review and publish-review were considered for wiring into the changeset release workflow but ruled out — the edge cases they cover (force merges, validate bugs, build-step divergence) are not applicable to this repo, and validate on PRs is sufficient.

Related Issues

Testing Instructions

  1. Open a PR that touches packages/ui-components/src/components/** or packages/ui-components/skills/** and verify the Check Skills workflow triggers
  2. Open a PR that touches unrelated files and verify it does not trigger

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
@ArtieReus
ArtieReus requested a review from a team as a code owner October 20, 2026 14:56
@changeset-bot

changeset-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 80ef1bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ArtieReus ArtieReus self-assigned this Oct 20, 2026
@ArtieReus
ArtieReus merged commit 070f53f into 2094-setup-tanstack-intent Oct 20, 2026
21 checks passed
@ArtieReus
ArtieReus deleted the artie-inetnt-ci-check branch October 20, 2026 14:58
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-20 14:58 UTC

taymoor89 pushed a commit that referenced this pull request Oct 21, 2026
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
taymoor89 pushed a commit that referenced this pull request Oct 21, 2026
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Taimoor Aslam <taimoor.aslam@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant