Skip to content

Fix support for high-availability LDAP authentication (2+ servers) #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flowln wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix support for high-availability LDAP authentication (2+ servers) #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/bluesky_httpserver/authenticators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,14 +1011,8 @@ async def resolve_username(self, username_supplied_by_user):
def get_connection(self, userdn, password):
import ldap3

# NOTE: setting 'active=False' essentially disables exclusion of inactive servers from the pool.
# It probably does not matter if the pool contains only one server, but it could have implications
# when there are multiple servers in the pool. It is not clear what those implications are.
# But using the default 'activate=True' results in the thread being blocked indefinitely
# at the step of creating 'ldap3.Connection' regardless of timeouts in case all the servers are
# inactive (e.g. the pool has one server and it is unaccessible), which is unacceptable.
# Further investigation may be needed in the future.
server_pool = ldap3.ServerPool(None, ldap3.RANDOM, active=False)
# Try connecting to some server in the pool up to 3 times, before failing.
server_pool = ldap3.ServerPool(None, ldap3.RANDOM, active=3)
for address in self.server_address_list:
if re.search(r".+:\d+", address):
# Port is found in the address
Expand Down
Loading