Repository navigation
Conversation
When using 'active=False', the ServerPool object returns only an index of a server to use (in this case, an index of a random server), without checking whether that server is currently active (reachable) [1]. This means that in a setup with two or more servers in the pool, if one or more of them are down (e.g. for maintenance), there's a random chance that server is picked, resulting in an error. Setting 'active' to an integer prevents that by making the pool loop through all servers to check which ones are available, but does not block the thread indefinitely as setting it to 'True' would. [1] - https://github.com/cannatag/ldap3/blob/c5be4b6f/ldap3/core/pooling.py#L95 Signed-off-by: Sofia Donato Ferreira <sofia.ferreira@lnls.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
active=False, theServerPoolobject uses only an index of a server (in this case, an index of a random server), without checking whether that server is currently active (reachable) (ref).This means that in a setup with two or more servers in the pool, if one or more of them are down (e.g. for maintenance), there's a random chance that server is picked, resulting in an error.
Setting 'active' to an integer prevents that by making the pool loop through all servers to check which ones are available, but does not block the thread indefinitely as setting it to
Truewould. This is corroborated by the documentation on ServerPool.Summary of Changes for Release Notes
Fix support for high-availability LDAP authentication (2+ servers)
Fixed