Skip to content

aisix: support Deployment metadata annotations - #410

Closed
JensErat wants to merge 1 commit into
api7:mainfrom
JensErat:main
Closed

JensErat wants to merge 1 commit into
api7:mainfrom
JensErat:main

Conversation

@JensErat

Copy link
Copy Markdown
Contributor

The helm chart misses support for setting anontations on the deployment, for example when using reloader or similar tools.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0d348bed-0cad-4280-afc1-bfe8ba1ed280
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@jarvis9443

Copy link
Copy Markdown
Contributor

Thanks for this, the change looks good. We're folding it into the 1.7.0 chart release in #408 (your commit is merged into that branch as-is), so it ships with aisix-1.7.0. I'll close this one once #408 lands.

@jarvis9443 jarvis9443 mentioned this pull request Oct 22, 2026
nic-6443 pushed a commit that referenced this pull request Oct 22, 2026
Both aisix charts move to version and appVersion 1.7.0. charts/aisix-cp is synced from AISIX-Cloud v1.7.0 (api.outbound.ssrfProtection replaces the four per-site private-address switches; checksum/secret pod annotations), preserving the public adaptations. charts/aisix folds #409 (upstream.media_fetch, upstream.bedrock.mantle_endpoint, outbound.ssrf_protection), #410 (Deployment metadata annotations) and #405 (drops the retired observability.usage_event.request_headers).

Co-authored-by: Jens Erat <628441+JensErat@users.noreply.github.com>
@jarvis9443

Copy link
Copy Markdown
Contributor

Shipped in the 1.7.0 chart release via #408 (merged, with you credited as co-author). Thanks again!

@jarvis9443 jarvis9443 closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants