Skip to content

[Fix] Restore DataNode cleanup after migration failures #18945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CRZbulabula wants to merge 1 commit into from
Closed

[Fix] Restore DataNode cleanup after migration failures #18945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...c/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,9 @@ protected long getRollbackRetryTimeout() {

@Override
protected boolean isRollbackSupported(RemoveDataNodeState state) {
return false;
// Child migration failures are reported after the parent has advanced to STOP_DATA_NODE.
// Roll back there so drained nodes are stopped and failed migrations restore their statuses.
return state == RemoveDataNodeState.STOP_DATA_NODE;
}

/**
Expand Down
Loading