Repository navigation
[Fix] Restore DataNode cleanup after migration failures - #18945
Closed
CRZbulabula wants to merge 1 commit into
Closed
CRZbulabula wants to merge 1 commit into
CRZbulabula wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RemoveDataNodesProcedurereported rollback as unsupported for every state. After commit-point rollback gating was introduced, a child migration failure atSTOP_DATA_NODEskipped the parent cleanup, leaving failed DataNodes inRemovingand failing the ConfigNode unit test on Linux and Windows.Solution
STOP_DATA_NODE, where the existing rollback hook restores failed node statuses and stops fully migrated nodes.Validation
mvn -pl iotdb-core/confignode -am -Dtest=RemoveDataNodesProcedureTest#metadataRetryExhaustionRetriesFailedNodeStatusCleanup -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false testmvn spotless:apply -pl iotdb-core/confignode