Skip to content

[Test] Fix WAL gap recovery assertions for lazy multi-writer replay #18942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jt2594838 merged 2 commits into from
Oct 21, 2026
Merged

[Test] Fix WAL gap recovery assertions for lazy multi-writer replay #18942

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0045ff
[Test] Align WAL replay and pipe permission assertions with runtime b…
Caideyipi Oct 20, 2026
179cf8d
[Test] Keep existing pipe database-count expectations
Caideyipi Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .../iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueueWalBackpressureTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,11 +373,13 @@ private void assertWalGapRecoveryResumesRealtime(
deliveredLocalSeq, event.getCommitContext().getWriterProgress().getLocalSeq());
assertTrue(queue.ack("consumer", event.getCommitContext()));
}
assertEquals(
followerBeforePending ? oneTabletBytes : 0L, memoryManager.getUsedMemorySizeInBytes());
// Ordered replay retains blocked writer heads as raw requests until they can be emitted.
assertEquals(0L, memoryManager.getUsedMemorySizeInBytes());
}
assertEquals(requestCount, deliveredLocalSeq);
if (followerBeforePending) {
assertTrue(queue.getRetainedRequestBytes() > 0L);
assertEquals(queue.getRetainedRequestBytes(), requestMemoryBlock.getUsedMemoryInBytes());
// The replicated writer's later timestamp lets local requests drain in order. Removing
// the local writer then releases that final follower entry without reading it again.
queue.setActiveWriterNodeIds(Collections.singleton(WRITER_NODE_ID + 1));
Expand Down Expand Up @@ -411,7 +413,7 @@ private void assertWalGapRecoveryResumesRealtime(
missingWalGap
? Arrays.asList(2L, 3L, 4L, 5L, 6L, 7L, 8L)
: (followerBeforePending
? Arrays.asList(1L, -1L, 2L, 3L, 4L, 5L, 6L, 7L, 8L)
? Arrays.asList(1L, 2L, 3L, 4L, 5L, 6L, 7L, 8L, -1L)
: Arrays.asList(1L, 2L, 3L, 4L, 5L, 6L, 7L, 8L)),
conversions);
}
Expand Down
Loading