Repository navigation
[Test] Fix WAL gap recovery assertions for lazy multi-writer replay - #18942
Merged
jt2594838 merged 2 commits intoOct 21, 2026
Merged
Conversation
Caideyipi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
testWalGapRecoveryPreservesFollowerBeforePendingBoundaryexpects a blocked follower to retain a materialized Tablet, but ordered multi-writer replay now keeps the follower as a raw request until it can be emitted. This deterministically fails withexpected:<1318> but was:<0>.Update the test to check that Tablet memory is released after each local ACK, that the blocked follower remains accounted for in consensus request memory, and that conversion follows delivery order. Preserve the final follower-delivery and complete memory-release assertions.
Validation
origin/masteragainst local reactor dependencies: reproduced the reported failure (10 tests, 1 failure).