Repository navigation
Amber CLI 2.0.11 on Amber 2.0.0-beta.11, Grant 0.24.0 and asset_pipeline 0.38.0 - #57
Merged
Merged
Conversation
scripts/check_generated_app_linkage.sh generates the default SQLite app, builds it, and fails when its binary links libpcre2 or holds a pcre2_ symbol; it repeats the check after a scaffold adds a Grant model, and a Regex control program proves the check can fail. The generated-app-linkage CI job runs it on ubuntu-24.04 and macos-15 with sha256-verified Crystal 1.22.2.
…ine 0.38.0 New apps pin Amber v2.0.0-beta.11 (f987f1bb), Grant v0.24.0 (7bb4b9d4) and asset_pipeline v0.38.0 (73c89c34) by commit. amber new checks every one of them in shard.lock: its commit and its sha256-v2 checksum, or the git-tree checksum an older Minecart records, and on Windows its commit alone. The three releases live in PinnedRelease values, so the lock check is one loop. The generated-app-linkage CI job checks that the default app links no PCRE2 before and after a scaffold, and the beta contract requires it.
The darwin tarball ships shards only in embedded/bin, so Minecart could not run micrate's postinstall script. Add embedded/bin after bin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #55, whose branch pinned the pre-release branch heads.
What changes
v2.0.0-beta.11(f987f1bb19b789f8f14b000b6ee00ed496fe6cbb), Grantv0.24.0(7bb4b9d45e74c490e6f3ad80cef8cc1cebd5b889) and asset_pipelinev0.38.0(73c89c3417a5282d9ac4179b283bcc660b7f898a).amber newchecks each of them inshard.lockthe way 2.0.10 checked Amber: the commit in the version line plus thesha256-v2:checksum, or thegit-tree:checksum an older Minecart records, and on Windows the commit alone.AmberCLI::PinnedReleaseholds each release (src/amber_cli/pinned_releases.cr), and the lock check loops overLIST_OF_PINNED_RELEASES.sha256-v2:732bd8a19fed53e2e8ef0ee768dab03466abf502324d55de5f81961ac75456fa, treefc2433e6cf3b55fc779977cc70b1270c7910c920sha256-v2:0c295bd9da92146c5482c63326adb402b24e33c152af86025a27f9da1a086f51, treeac01af3a3edb7d881c798c755e0845ad04383225sha256-v2:80ea8ac95943a3c5be438e68c2ef2f00d9b9783f0787fcd67ef346f135d9510c, tree42caf3fc2d1af5e97417e7d7947dddd025e405e1scripts/check_generated_app_linkage.shand thegenerated-app-linkageCI job (ubuntu-24.04, macos-15, sha256-verified Crystal 1.22.2). The script now resolves a relative output directory before it changes into the app.Checked locally (crystal-alpha 1.21.0, macOS arm64, Minecart 2025.11.25.9)
scripts/check_generated_app_linkage.sh: the control program shows PCRE2 (1 library, 13pcre2_symbols); the default app links no PCRE2 and answersGET /with 200; the scaffolded app links no PCRE2 and its specs pass (12 examples, 0 failures).scripts/smoke_generated_web.sh ./amberpasses, andscripts/check_beta_contract.shpasses.crystal spec: 779 examples; the 6 that fail need a builtbin/amber-lsp(spec/amber_lsp/integration), which CI builds. The new-command, native-app and doctor specs pass (188 examples, 0 failures). Format check is clean and the CLI compiles with no warnings.