Repository navigation
Pin the regex-free beta.11 branches and gate CI on generated-app linkage - #55
Closed
crimson-knight wants to merge 2 commits into
Closed
crimson-knight wants to merge 2 commits into
crimson-knight wants to merge 2 commits into
Conversation
Amber, Grant and asset_pipeline now pin the heads of amberframework/amber#1451, crimson-knight/grant#73 and amberframework/asset_pipeline#25, with the Amber tree and Minecart sha256-v2 checksum for that commit. These are integration pins; they become release-tag commits before this branch merges.
scripts/check_generated_app_linkage.sh generates the default SQLite app, builds it, and fails when its binary links libpcre2 or holds a pcre2_ symbol; it repeats the check after a scaffold adds a Grant model, and a Regex control program proves the check can fail. The generated-app-linkage CI job runs it on ubuntu-24.04 and macos-15 with sha256-verified Crystal 1.22.2.
Member
Author
|
Replaced by #57, which pins the released Amber v2.0.0-beta.11, Grant v0.24.0 and asset_pipeline v0.38.0 and carries this branch's linkage gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration branch for Amber 2.0.0-beta.11: the app
amber newgenerates should build and run with no libpcre2 linked.Depends on
fix/1425-respond-with-named-tuple, 43a36141)grant-regex-free-default-path, fe59cbc5)regex-free-default-require, abbef01d)What changes
new_command.cr,templates/app/shard.yml.ecr) andAmberReleasepin those three branch heads by commit. The Amber entry carries its tree (332d04b4) and Minecart checksum (sha256-v2:f58fc614...). Specs,check_beta_contract.shand the smoke scripts follow the new pins.v2.0.0-beta.11), andAmberRelease::VERSIONbecomes2.0.0-beta.11.scripts/check_generated_app_linkage.shand thegenerated-app-linkageCI job (ubuntu-24.04, macos-15, sha256-verified Crystal 1.22.2). The job generatesamber new linkage_probe -d sqlite, builds the app, checks that it links no libpcre2 and holds nopcre2_symbol, and checks thatGET /answers 200. It repeats the build and check afteramber generate scaffoldadds a Grant model, then runs the app's specs. A control program that usesRegexmust show PCRE2, which proves the check can fail.Status on macOS (crystal-alpha 1.21.0)
GET /answers 200.libpcre2-8.0.dylib(13pcre2_symbols). The only reachable Regex isComponents::Cache::PageAnswer#refuses_coding?(asset_pipeline/src/components/cache/page_answer.cr:90,/(^|;)q=0(\.0*)?$/). The generatedconfig/initializers/page_cache.crrequiresasset_pipeline/components/cache/configuration, which loads it. With that one method replaced by a hand-written check (0 mismatches over 200,036 inputs), both the default app and the scaffolded app link no PCRE2, specs pass and pages answer 200. That fix belongs in Make the default require path regex-free (0.38.0) asset_pipeline#25.This PR stays a draft until the three upstream PRs merge and are tagged.