Repository navigation
feat(ui): add time and date format settings and message timestamps #2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KarthickMahalingam
wants to merge
46
commits into
Zoo-Code-Org:main
Choose a base branch
from
KarthickMahalingam:feat/time-date-format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,995
−61
Open
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
738bc87
feat(ui): add time and date format settings and message timestamps
KarthickMahalingam c987648
fix(ui): address review feedback on time and date settings
KarthickMahalingam 61b734e
test(visual): add Language tab baselines
KarthickMahalingam c8d7492
test(e2e): mask the message time in the extension host visual test
KarthickMahalingam d0b39ed
test(e2e): update the chat sidebar baseline for the message time
KarthickMahalingam daa83bd
Merge branch 'main' into feat/time-date-format
KarthickMahalingam d11277a
test(e2e): give the masked message time a fixed width so the mask box…
KarthickMahalingam 8e1aed2
test(e2e): iterate the message times with forEach (no DOM.Iterable in…
KarthickMahalingam 34c1d1d
test(e2e): regenerate the chat sidebar baseline from CI with a fixed-…
KarthickMahalingam 9a3c483
feat(ui): make the time format a real radio group with roving focus a…
KarthickMahalingam 36548f9
test(host): cover saving the date and time settings and returning the…
KarthickMahalingam 6dd6cb9
test(ui): cover the date format on older messages across user, assist…
KarthickMahalingam 994486a
test(e2e): pin the masked message time to one fixed-size line, and up…
KarthickMahalingam 6aaffc2
refactor(ui): drop the unused formatDate; no tooltip that repeats an …
KarthickMahalingam 611b7cf
fix(ui): select the time format option that receives focus; keep keyb…
KarthickMahalingam 4f9bc9f
test: assert the webview state refresh after a save; cover the date f…
KarthickMahalingam 6944e2d
test(ui): cover the task header time and the display language fallback
KarthickMahalingam 1f677d5
fix(ui): save the three date and time settings all-or-nothing
KarthickMahalingam 12ea356
test(ui): cover the message time while editing, and an invalid task t…
KarthickMahalingam f5193d2
fix(ui): unwind overlapping failed saves in any order, keep imports, …
KarthickMahalingam 637e76b
fix(import): restore display settings if settings import write fails
KarthickMahalingam 0efb6bb
fix(import): wait for every display write before restoring
KarthickMahalingam 3a8f994
fix(import): say which display settings could not be restored
KarthickMahalingam 3fc95ed
refactor: one write chain for saves and imports of the display settings
KarthickMahalingam 7e2147a
fix: validate display values, order writes per key down to storage, r…
KarthickMahalingam c300b70
test: cover the handed-over previous value of a queued write
KarthickMahalingam 09a22d8
Merge branch 'main' into feat/time-date-format
KarthickMahalingam 7734ee7
fix: keep a store made outside a save when a failed write is rolled back
KarthickMahalingam ee38a57
Merge branch 'main' into feat/time-date-format
KarthickMahalingam 80e48a2
fix: count only stores by others, and re-read a handed-over value if …
KarthickMahalingam e01f9a2
fix: a finished write is the base of a later queued one; no empty blo…
KarthickMahalingam c0e7c3b
test: cover a write that had started when the earlier one finished
KarthickMahalingam 51587ed
fix(import): keep the display writes active until every step has succ…
KarthickMahalingam 642c1a6
Merge branch 'main' into feat/time-date-format
KarthickMahalingam b54a377
fix: hand a rolled-back value on only while nobody else stored the ke…
KarthickMahalingam c9bc5d4
fix: count only stores by others directly, marking the store being is…
KarthickMahalingam 703d386
fix: a rejected outside store of a tracked setting is not a store to …
KarthickMahalingam 6201ccb
fix: number the stores by others, so a rejected one cancels only itself
KarthickMahalingam 3716fcf
Merge branch 'main' into feat/time-date-format
KarthickMahalingam 06d2c77
fix: keep the stores by others only while a write of the key is pending
KarthickMahalingam 047de2c
fix: keep recording stores by others while the restore of an undone w…
KarthickMahalingam 7576fce
test: two restores waiting for one key
KarthickMahalingam dfe4c16
refactor: one helper for the count of waiting restores
KarthickMahalingam 656361b
Merge branch 'main' into feat/time-date-format
KarthickMahalingam f35e5fe
fix: put the cache back when a store of a tracked setting is rejected
KarthickMahalingam 9eaa8ed
Merge branch 'main' into feat/time-date-format
KarthickMahalingam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
-898 Bytes
(97%)
apps/vscode-e2e/src/visual/__screenshots__/electron-chat-dark-sidebar.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.