Repository navigation
Resolve merged TypeScript classes in hierarchy and class coverage - #517
Merged
Merged
Conversation
CaelmBleidd
force-pushed
the
caelmbleidd/ts-declaration-merging-hierarchy
branch
from
October 15, 2026 13:00
1528406 to
3a77b2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid TypeScript class/interface declaration merging produces two EtsIR declarations with the same signature. The hierarchy's
single()lookup treated them as duplicate runtime classes and aborted initial-state construction before any class statement ran. OriginalReplacerandHashTablesources exposed this failure in the fixed 200-class startup smoke.Resolve a same-signature group to its unique
CLASSonly when every other declaration is anINTERFACEaugmentation. Reuse that canonical declaration selection for explicit CLASS-zone coverage targets, which otherwise rejected the same valid merged group after initial-state creation. Keep the complete scene and interface metadata and track the runtime class's full methods. Other ambiguous groups, including two runtime classes, retain the existing failure behavior; missing/foreign target identities still fail exact signature checks.Validation: the original ten focused hierarchy/type/field checks pass. The follow-up passes all sixteen merging/class-coverage checks (four merging checks and twelve existing class-coverage checks), including an explicit target signature on the real source fixture. Restoring the original hierarchy lookup makes the source regression fail with
List has more than one element; restoring only the old CLASS target lookup makes the new test fail withClass coverage targets must identify one scene class each, matching the two original Replacer startup receipts. Both changes are restored and the focused checks rerun successfully. Strictusvm-tsmain/test Detekt reports zero findings. Full suites are left to CI; the real-corpus subset is rechecked in the integrated runtime.