Skip to content

net11.0: append to Features, and skip Logging.Abstractions where the framework has it #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgravell merged 1 commit into from
Oct 15, 2026
Merged

net11.0: append to Features, and skip Logging.Abstractions where the framework has it #3276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/StackExchange.Redis/StackExchange.Redis.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<DefineConstants Condition="'$(TargetFramework)' != 'net461'">$(DefineConstants);VECTOR_SAFE</DefineConstants>

<!-- see the IncludePreviewTargets note above; this is half the opt-in, RuntimeAsync.cs is the other -->
<Features Condition="'$(TargetFramework)' == 'net11.0' and '$(DisableRuntimeAsync)' != 'true'">runtime-async=on</Features>
<Features Condition="'$(TargetFramework)' == 'net11.0' and '$(DisableRuntimeAsync)' != 'true'">$(Features);runtime-async=on</Features>
<DefineConstants Condition="'$(TargetFramework)' != 'net461' and '$(TargetFramework)' != 'net472' and '$(TargetFramework)' != 'netstandard2.0'">$(DefineConstants);UNIX_SOCKET</DefineConstants>
<PackageReadmeFile>README.md</PackageReadmeFile>

Expand All @@ -49,8 +49,9 @@
</ItemGroup>

<ItemGroup>
<!-- in the shared framework from net11.0, where the explicit reference is pruned and NU1510 fails the build -->
<PackageReference Condition="!$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0'))" Include="Microsoft.Extensions.Logging.Abstractions" />
<!-- needed everywhere -->
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
<PackageReference Include="System.IO.Hashing" />

<!-- pipelines is built in from .NET 10 onwards -->
Expand Down
2 changes: 1 addition & 1 deletion tests/StackExchange.Redis.Benchmarks/StackExchange.Redis.Benchmarks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
benchmark method's OWN state machine survives and masks part of what the library saved.
-->
<PropertyGroup Condition="'$(TargetFramework)' == 'net11.0' and '$(DisableRuntimeAsync)' != 'true'">
<Features>runtime-async=on</Features>
<Features>$(Features);runtime-async=on</Features>
</PropertyGroup>
<ItemGroup Condition="'$(TargetFramework)' != 'net11.0' or '$(DisableRuntimeAsync)' == 'true'">
<Compile Remove="RuntimeAsyncOptIn.cs" />
Expand Down
Loading