Repository navigation
net11.0: append to Features, and skip Logging.Abstractions where the framework has it - #3276
Merged
Merged
Conversation
…d drop the Logging.Abstractions reference where it is in the shared framework (NU1510)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two csproj fixes found while building v4 for net11.0 with runtime async:
<Features>now appends ($(Features);runtime-async=on, likewise in the benchmarks project). It used to assignruntime-async=onoutright, which threw awaystrict(from Directory.Build.props) on net11.0 builds.Microsoft.Extensions.Logging.Abstractionsis referenced only below net11.0. From net11.0 it is in the shared framework, the explicit reference is pruned, and NU1510 fails the build under the repo'sTreatWarningsAsErrors.Context: https://github.com/seredis/dotnet11-threadpool-repro builds v4 for net11.0 with runtime async on and off; it currently works around both points with an injected targets file.