Repository navigation
Rename the sparse_linalg library to sparsediff_linalg - #141
Merged
Merged
Conversation
The library will become its own repository, consumed back as a submodule, so its repository name, submodule mount path, CMake target and include prefix should agree. sparsediff_linalg says what the library is for, follows the organization's SparseDiff naming, and removes the collision risk of a generic "sparse_linalg/matrix.h" in a shared include path. Mechanical rename, no C symbol changes: directory sparse_linalg/ -> sparsediff_linalg/ include prefix "sparse_linalg/<name>.h" -> "sparsediff_linalg/<name>.h" target/alias sparse_linalg(::) -> sparsediff_linalg(::) options SPARSE_LINALG_* -> SPARSEDIFF_LINALG_* (SP_TRACK_MEMORY kept) test executable sparse_linalg_tests -> sparsediff_linalg_tests ctest entry SparseLinalgTests -> SparseDiffLinalgTests Workflows follow the new binary path and standalone source dir. Verified: all 76 library and engine Release objects byte-identical to main (only the test main differs, by its banner strings); 310 + 159 tests, 162 with SP_TRACK_MEMORY; ctest 2/2; 7 profiles; standalone Release and Debug; injected layering violations still fail configure; clang-format clean. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library is about to become its own repository, consumed back as a submodule, so its repository name, submodule mount path, CMake target and include prefix should all agree.
sparsediff_linalgsays what the library is for, follows the organization's SparseDiff naming, and removes the collision risk of a genericsparse_linalg/matrix.hin a shared include path. Doing it in-tree, before the split, keeps it a single mechanical PR verifiable by byte-identical objects.Mechanical rename, no C symbol changes:
sparse_linalg/sparsediff_linalg/"sparse_linalg/<name>.h""sparsediff_linalg/<name>.h"sparse_linalg,sparse_linalg::sparse_linalgsparsediff_linalg,sparsediff_linalg::sparsediff_linalgSPARSE_LINALG_BUILD_TESTS,SPARSE_LINALG_WARNINGS_AS_ERRORSSPARSEDIFF_LINALG_*(SP_TRACK_MEMORYunchanged)build/sparse_linalg/sparse_linalg_testsbuild/sparsediff_linalg/sparsediff_linalg_testsSparseLinalgTestsSparseDiffLinalgTests317 include lines across 118 files, the two CMakeLists, six workflows (binary path and standalone
-Sdir), two comments and the test banner strings.Verified locally (macOS):
.ofiles byte-identical tomain; the only differing object is the library test main, whose banner strings changedall_tests310/310,sparsediff_linalg_tests159/159,ctest2/2; withSP_TRACK_MEMORY=ON310 + 162PROFILE_ONLYbuild runs all 7 profilescmake -S sparsediff_linalgin Release and Debug: builds, ctest 1/1expr.h, public header →internal/, test →problem.h, standalone library →expr.h) each fail configure; clean tree configurespip install -e .builds and passes its recipe smoke test against this checkout🤖 Generated with Claude Code