Repository navigation
Consume sparsediff_linalg as a git submodule - #142
Merged
Merged
Conversation
The library now lives in its own repository, https://github.com/SparseDifferentiation/sparsediff_linalg, extracted with its full history. The in-tree copy is replaced by a submodule at the same path, pinned to v0.1.0, so the root CMakeLists.txt still does add_subdirectory(sparsediff_linalg) and nothing else about the build changes. A plain clone leaves the directory empty, so configure now stops with a hint to run `git submodule update --init --recursive`. Every workflow that builds checks out submodules recursively; the formatting check prunes the submodule so it covers engine files only (the library's own CI formats its files). Verified: all 77 Release objects byte-identical to main; 310 + 159 tests, ctest 2/2, 162 with SP_TRACK_MEMORY, 7 profiles; a plain clone fails configure with the hint and succeeds after submodule init from GitHub; SparseDiffPy builds and passes its smoke test against this checkout. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library now lives in its own repository, SparseDifferentiation/sparsediff_linalg, extracted with
git filter-reposo its full history (back to theinclude/utilsera, 96 commits) came along. This PR replaces the in-tree copy with a submodule at the same path, pinned to v0.1.0, soadd_subdirectory(sparsediff_linalg)and every target name stay exactly as they were.Changes:
sparsediff_linalg/is now a submodule (.gitmodules: https URL, so CI and SparseDiffPy clone it without credentials). The pinned commit is the tagged release, whose tree is the merged Rename the sparse_linalg library to sparsediff_linalg #141 tree plus LICENSE/README/CI/VERSION 0.1.0.CMakeLists.txt: a plain clone leaves the directory empty, so configure now stops with aFATAL_ERRORthat says to rungit submodule update --init --recursive.submodules: recursive.formatting.ymlprunes./sparsediff_linalgso the engine's check covers engine files only; the library's own CI formats its files.release.yml's release job (which only creates the GitHub release) keeps a plain checkout.Workflow from now on: library changes are PRs in the library repo, released by tag; an engine PR then bumps the pin with
git -C sparsediff_linalg checkout vX.Y.Z.Verified locally (macOS):
.ofiles byte-identical tomainall_tests310/310,sparsediff_linalg_tests159/159,ctest2/2;SP_TRACK_MEMORY=ON310 + 162;PROFILE_ONLYruns all 7 profilesgit submodule update --init --recursive(fetched from GitHub, lands on v0.1.0) it configurespip install -e .builds against this checkout and passes its recipe smoke testFollow-up for SparseDiffPy (separate PR there): bump the engine pin, build a local sdist and confirm
SparseDiffEngine/sparsediff_linalg/is inside it, drop the staleinclude/utilsinclude dir, and re-point the conda-forge BLAS patch atsparsediff_linalg/CMakeLists.txt.🤖 Generated with Claude Code