Repository navigation
fix(feedback): decouple local diagnostics from remote refresh - #4816
Closed
ScriptedAlchemy wants to merge 1 commit into
Closed
ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
… refresh Route local LSP and hook feedback without polling GitHub review refresh or CI discovery. Keep explicit advisory demand on its existing authorized remote refresh path, and preserve typed unavailable remote provider states. Add production-selector regressions proving a blocked remote CI read cannot be polled by local feedback and an explicit read waits for its own barrier. Refs #4423
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Refs #4423 — isolate the editor/LSP/hook feedback path from remote refresh I/O. This PR is draft because full retained-remote-evidence acceptance is not yet complete.
Production change
DaemonAdvisoryCycleInvocationPort::invokeon the existing explicit GitHub/CI refresh path.refresh_githubremains its own authorized operation.AdvisoryRuntime::run_once, publication and hook delivery, cancellation/deadlines, and proximity evaluation. Unrequested remote providers retain typedUnavailableoutcomes; local completion never means remote success. No configuration or authorization checks are bypassed.Verification
The two-file commit
ece7d27f09383c27ab341f0fa0c7fcbb6f4dc776was independently reviewed against master91c72aba7750a398dd28e83d64bf0c6d6fef4172. It changes the existing daemon owner and its existing tests; no generated contracts or unrelated PRs were edited.Rust/Bazel tests are not yet executed. The authoring runtime lacks Bazel and Rust; use hosted Bazel CI for
//crates/tracedecay:unit_test,//crates/tracedecay:runtime_acceptance_suite, LSP/hook and repository-wide gates. Do not mark this ready or merge from static review.Remaining acceptance
Protected mixed draft #4776 and release #4763 are untouched.
Superseded by a non-force successor (2026-11-08)
Hosted Repository gates confirmed this PR's original commit header has 77 characters and fails the 72-character
authored-header-max-lengthcheck. Appending commits cannot correct an already published commit, and a force-push is prohibited for this task. A successor draft branch retains this exact production patch and both barrier regressions, adds typed CI-provider-state correctness, and uses a valid commit header. This PR is closed without merge or deletion; its source and discussion remain accessible.