Repository navigation
fix(feedback): isolate local diagnostics from remote refresh - #4817
Draft
ScriptedAlchemy wants to merge 2 commits into
Draft
ScriptedAlchemy wants to merge 2 commits into
ScriptedAlchemy wants to merge 2 commits into
Conversation
Retain explicit GitHub/CI refresh while keeping editor and hook feedback independent of unrequested provider reads. Keep configured-but-unqueried CI distinct from an absent CI binding so policy cannot imply success. Preserve the original two barrier regressions and test both configured and unconfigured local admission. Supersedes #4816 without rewriting its published commit or changing another contributor's branch. Refs #4423
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Refs #4423 — partial, DRAFT. Supersedes closed PR #4816 because its original 77-character commit header failed the 72-character CI commitlint gate. This replacement copies the complete production change and existing barrier regressions unchanged and adds a provider-state correctness regression. No force-push or rewrite of the prior contributor commit.
Source changes
Regression evidence and validation
Three authored nonzero Rust tests: (1) local feedback cannot even poll a forbidden CI read and excludes GitHub refresh; (2) unconfigured local feedback cannot poll CI and stays NotConfigured; (3) an explicitly requested remote read cannot complete until its barrier releases and propagates Denied. Existing assertions are preserved.
Reviewed exact one-commit diff from master
91c72aba7750a398dd28e83d64bf0c6d6fef4172: two source/test files only, 155 insertions/19 deletions. Commitcb2fa59dc18aee0771a52bf4dd7b8030099520bahas a conforming 58-character header. Source changes were transferred without force from closed #4816, and a new typed-state regression was added.The new-head Rust/Bazel tests have not executed. Hosted CI is mandatory:
//crates/tracedecay:unit_test, owning advisory/runtime/LSP/hook integration, Clippy and repository gates. Native macOS acceptance remains unavailable here. Do not mark ready/merge from diff review alone.Remaining acceptance
Already-retained remote evidence must attach only under exact authorization, scope, generation, configuration and freshness; remote-required policy must remain fail-closed; test full editor/hook/explicit-refresh journeys and cancellation separation; measure actual provider calls; remove obsolete provider waits/fields only when all consumers are migrated. No issue closure or performance benchmark claim.
Protected #4776 and release #4763 untouched.
CI correction — 2026-11-08
Hosted Repository gates confirmed the Bazel
rustfmt_check_2024rule failed on five formatting hunks (two source regions and two test regions; the source map change appears as two rustfmt diffs). Commit2cc04d4applies those exact reported changes. Its independently reviewed diff changes formatting only; all existing regression assertions and production behavior remain intact. The branch was advanced by non-force fast-forward after exact old-head verification. Exact-head CI #42493863604 is queued, not passed. Rust/Bazel behavior and native macOS acceptance remain unverified. Do not merge or close #4423.