Skip to content

fix(feedback): isolate local diagnostics from remote refresh - #4817

Draft
ScriptedAlchemy wants to merge 2 commits into
masterfrom
fix/4423-local-feedback-isolation-v2
Draft

ScriptedAlchemy wants to merge 2 commits into
masterfrom
fix/4423-local-feedback-isolation-v2

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Scope

Refs #4423 — partial, DRAFT. Supersedes closed PR #4816 because its original 77-character commit header failed the 72-character CI commitlint gate. This replacement copies the complete production change and existing barrier regressions unchanged and adds a provider-state correctness regression. No force-push or rewrite of the prior contributor commit.

Source changes

  • Local editor/LSP and hook feedback no longer starts GitHub review refresh or CI discovery, so independently authorized code diagnostics can proceed despite a remote read that hangs, fails, or is denied.
  • Explicit advisory invocation continues to await requested GitHub/CI remote reads under its authorized deadline.
  • A configured remote CI provider deliberately not read during a local cycle is Unavailable, not NotConfigured. A genuinely absent CI configuration retains NotConfigured; no local pass can imply remote evidence was fetched.
  • Preserves the canonical advisory/feedback owner, operation event, selected configuration/generation, proximity and delivery path. No new scheduler or provider cache.

Regression evidence and validation

Three authored nonzero Rust tests: (1) local feedback cannot even poll a forbidden CI read and excludes GitHub refresh; (2) unconfigured local feedback cannot poll CI and stays NotConfigured; (3) an explicitly requested remote read cannot complete until its barrier releases and propagates Denied. Existing assertions are preserved.

Reviewed exact one-commit diff from master 91c72aba7750a398dd28e83d64bf0c6d6fef4172: two source/test files only, 155 insertions/19 deletions. Commit cb2fa59dc18aee0771a52bf4dd7b8030099520ba has a conforming 58-character header. Source changes were transferred without force from closed #4816, and a new typed-state regression was added.

The new-head Rust/Bazel tests have not executed. Hosted CI is mandatory: //crates/tracedecay:unit_test, owning advisory/runtime/LSP/hook integration, Clippy and repository gates. Native macOS acceptance remains unavailable here. Do not mark ready/merge from diff review alone.

Remaining acceptance

Already-retained remote evidence must attach only under exact authorization, scope, generation, configuration and freshness; remote-required policy must remain fail-closed; test full editor/hook/explicit-refresh journeys and cancellation separation; measure actual provider calls; remove obsolete provider waits/fields only when all consumers are migrated. No issue closure or performance benchmark claim.

Protected #4776 and release #4763 untouched.

CI correction — 2026-11-08

Hosted Repository gates confirmed the Bazel rustfmt_check_2024 rule failed on five formatting hunks (two source regions and two test regions; the source map change appears as two rustfmt diffs). Commit 2cc04d4 applies those exact reported changes. Its independently reviewed diff changes formatting only; all existing regression assertions and production behavior remain intact. The branch was advanced by non-force fast-forward after exact old-head verification. Exact-head CI #42493863604 is queued, not passed. Rust/Bazel behavior and native macOS acceptance remain unverified. Do not merge or close #4423.

Retain explicit GitHub/CI refresh while keeping editor and hook feedback
independent of unrequested provider reads. Keep configured-but-unqueried
CI distinct from an absent CI binding so policy cannot imply success.

Preserve the original two barrier regressions and test both configured
and unconfigured local admission. Supersedes #4816 without rewriting its
published commit or changing another contributor's branch.

Refs #4423
@changeset-bot

changeset-bot Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2cc04d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Apply the four source/test formatting hunks reported by the exact-head
Repository gates for #4817. Preserve all behavioral assertions and
remote-refresh isolation.

Refs #4423

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

simplify(feedback): remove remote refresh orchestration from the local editor feedback path

1 participant