Skip to content

chore(QOV-2504): remove secret export option #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benjaminch wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

chore(QOV-2504): remove secret export option #3185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libs/domains/environments/data-access/src/lib/domains-environments-data-access.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ describe('mutations.exportTerraform', () => {
jest.restoreAllMocks()
})

it.each([true, false])('should exclude secrets even if a caller supplies exportSecrets=%s', async (exportSecrets) => {
it('should request the Terraform archive as a blob without a secret export option', async () => {
const archive = new File(['terraform'], 'terraform.zip', { type: 'application/zip' })
const exportConfiguration = jest
.spyOn(EnvironmentExportApi.prototype, 'exportEnvironmentConfigurationIntoTerraform')
Expand All @@ -18,11 +18,11 @@ describe('mutations.exportTerraform', () => {
headers: {},
config: { headers: new AxiosHeaders() },
})
const request = { environmentId: '111', exportSecrets }
const request = { environmentId: '111' }

const result = await mutations.exportTerraform(request)

expect(exportConfiguration).toHaveBeenCalledWith('111', false, { responseType: 'blob' })
expect(exportConfiguration).toHaveBeenCalledWith('111', { responseType: 'blob' })
expect(result).toBe(archive)
})
})
2 changes: 1 addition & 1 deletion libs/domains/environments/data-access/src/lib/domains-environments-data-access.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ export const mutations = {
return result.data
},
async exportTerraform({ environmentId }: { environmentId: string }) {
const result = await environmentExportApi.exportEnvironmentConfigurationIntoTerraform(environmentId, false, {
const result = await environmentExportApi.exportEnvironmentConfigurationIntoTerraform(environmentId, {
responseType: 'blob',
})
return result.data
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"mermaid": "11.6.0",
"monaco-editor": "0.53.0",
"posthog-js": "1.345.1",
"qovery-typescript-axios": "1.1.1032",
"qovery-typescript-axios": "1.1.1035",
"react": "19.3.0",
"react-country-flag": "3.0.2",
"react-datepicker": "4.12.0",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6266,7 +6266,7 @@ __metadata:
prettier: 3.2.5
prettier-plugin-tailwindcss: 0.5.14
pretty-quick: 4.0.0
qovery-typescript-axios: 1.1.1032
qovery-typescript-axios: 1.1.1035
qovery-ws-typescript-axios: 0.1.666
react: 19.3.0
react-country-flag: 3.0.2
Expand Down Expand Up @@ -24366,12 +24366,12 @@ __metadata:
languageName: node
linkType: hard

"qovery-typescript-axios@npm:1.1.1032":
version: 1.1.1032
resolution: "qovery-typescript-axios@npm:1.1.1032"
"qovery-typescript-axios@npm:1.1.1035":
version: 1.1.1035
resolution: "qovery-typescript-axios@npm:1.1.1035"
dependencies:
axios: 1.20.0
checksum: b183794d7735a7f60bf5a69200e09340f61a1e866a8ef57f92a232e6d4967781c9e045b81262cbee3e3375a8b307fe9d50278a5886506f9e0f84b0421396cf5f
checksum: 8e7e1298543d015b1b474daa9899fdc4568d5e1dbeda3b54b898bde94c851da20e1b351c0784a051f6f1b46570b3a6bcc663a8f6da6ab281eddc6b904a971aba
languageName: node
linkType: hard

Expand Down
Loading