Skip to content

chore(QOV-2504): remove secret export option - #3185

Open
benjaminch wants to merge 1 commit into
stagingfrom
chore/QOV-2504/terraform-exporter-redact-secrets-v2
Open

benjaminch wants to merge 1 commit into
stagingfrom
chore/QOV-2504/terraform-exporter-redact-secrets-v2

Conversation

@benjaminch

@benjaminch benjaminch commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Issue: QOV-2504

Remove the option to include secrets when exporting an environment as Terraform.

  • Keep the confirmation dialog and replace the Export secrets toggle with “Secret values will not be exposed.”
  • Update qovery-typescript-axios to 1.1.1035 and remove the obsolete exportSecrets argument.
  • Preserve the ZIP download, cancellation and retry behavior.
  • Update tests to cover the confirmation dialog and the new API signature.

Requires the API change documented in [OpenAPI PR #1254](Qovery/qovery-openapi-spec#1254).

For review: open an environment, select Export as Terraform, confirm that no secrets toggle appears, then confirm the export and check that the ZIP downloads.

Screenshots / Recordings

No screenshots attached.

Testing

  • Changes tested locally in the relevant Console pages and Storybooks
  • Targeted tests: 103 tests and 11 snapshots passed
  • Formatting checked on modified files
  • Lint passed on modified files
  • TypeScript check passed for the Console

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible
  • I only kept necessary comments, written in English
  • I involved a designer to validate UI changes if I am not a designer
  • I covered the changed behavior with unit tests
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

Summary by cubic

Removes the option to export secrets when exporting an environment as Terraform. Updates qovery-typescript-axios to 1.1.1035, which drops the exportSecrets argument from the API, and updates tests to match.

Written for commit fa2f9ba. Summary will update on new commits.

View guided diff Turn on auto-fix

@benjaminch benjaminch added the enhancement New feature or request label Nov 6, 2026
@nx-cloud

nx-cloud Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit fa2f9ba

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 1m 10s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 4m 48s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 3m 10s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-11-06 14:14:21 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

View guided diff | Turn on auto-fix | Re-trigger cubic

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.16%. Comparing base (6f94cb9) to head (fa2f9ba).
⚠️ Report is 1 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #3185      +/-   ##
===========================================
- Coverage    55.50%   54.16%   -1.35%     
===========================================
  Files         1395     1447      +52     
  Lines        31307    32636    +1329     
  Branches      9508     9701     +193     
===========================================
+ Hits         17378    17678     +300     
- Misses       11228    12259    +1031     
+ Partials      2701     2699       -2     
Flag Coverage Δ
unittests 54.16% <100.00%> (-1.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants