Repository navigation
chore(QOV-2504): remove secret export option - #3185
benjaminch wants to merge 1 commit into
Conversation
Ticket: QOV-2504
|
View your CI Pipeline Execution ↗ for commit fa2f9ba
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #3185 +/- ##
===========================================
- Coverage 55.50% 54.16% -1.35%
===========================================
Files 1395 1447 +52
Lines 31307 32636 +1329
Branches 9508 9701 +193
===========================================
+ Hits 17378 17678 +300
- Misses 11228 12259 +1031
+ Partials 2701 2699 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Issue: QOV-2504
Remove the option to include secrets when exporting an environment as Terraform.
qovery-typescript-axiosto1.1.1035and remove the obsoleteexportSecretsargument.Requires the API change documented in [OpenAPI PR #1254](Qovery/qovery-openapi-spec#1254).
For review: open an environment, select Export as Terraform, confirm that no secrets toggle appears, then confirm the export and check that the ZIP downloads.
Screenshots / Recordings
No screenshots attached.
Testing
PR Checklist
.cursor/rules)Summary by cubic
Removes the option to export secrets when exporting an environment as Terraform. Updates
qovery-typescript-axiosto 1.1.1035, which drops theexportSecretsargument from the API, and updates tests to match.Written for commit fa2f9ba. Summary will update on new commits.