Repository navigation
Conversation
Proxies cannot gain or grant the player Cruelty, so Cruelty Support should not add its damage over time bonus when the main skill is used by a totem, trap or mine. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lemmertz
marked this pull request as ready for review
October 13, 2026 23:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5594 .
Description of the problem being solved:
Cruelty Support was granting its damage over time bonus even when the supported skill was used by a Totem, Trap or Mine. Per the wiki (citing a GGG forum post), proxies cannot gain or grant the player Cruelty.
The Cruelty multiplier and the "Cruelty" entry in the Combat Buffs list are now skipped when the main skill has the totem, trap or mine flag.
Steps taken to verify a working solution:
dev(v2.67.2, based on commit 16de4b8), Windows 11TestSkills_spec.lua(Cold Snap + Cruelty with/without Spell Totem, Trap, Blastchain Mine); it fails without the fixpathofbuilding-testsDocker image (585 successes)Link to a build that showcases this PR:
N/A
Before screenshot:
After screenshot:
AI disclosure: the investigation, code changes and test were made with Claude Code (model: Claude Opus 5.5,
claude-opus-5-5); testing in the app and screenshots were done by me.🤖 Generated with Claude Code