Repository navigation
refactor(connectors)!: let download return one value of any type - #822
Merged
masquare merged 3 commits intoNov 20, 2026
Conversation
masquare
force-pushed
the
refactor/connector-download-result
branch
from
November 19, 2026 17:34
584e088 to
54855d3
Compare
masquare
changed the base branch from
main
to
feature/tnet-175-add-the-autonlabtimeseriesexam1-connector
November 19, 2026 17:34
masquare
force-pushed
the
refactor/connector-download-result
branch
2 times, most recently
from
November 19, 2026 17:48
73e14ef to
9cfe435
Compare
masquare
marked this pull request as ready for review
November 19, 2026 18:53
karhu
approved these changes
Nov 19, 2026
karhu
left a comment
Contributor
There was a problem hiding this comment.
Added labels on GH, other than that, LGTM
masquare
force-pushed
the
refactor/connector-download-result
branch
from
November 20, 2026 07:25
9cfe435 to
90bd9a6
Compare
✅ CI checks passed
Updated for |
BaseConnector is generic over the whole download result, not over the item type of a list. A connector that fetches one handle returns the handle and takes it in convert, so the list with one item and the raw_refs[0] lookup are gone. The raw argument of compose and convert is positional-only, so a connector can name it.
…_cot after what it holds
masquare
force-pushed
the
refactor/connector-download-result
branch
from
November 20, 2026 15:31
90bd9a6 to
d70e749
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR and the one above sit on top of the TimeSeriesExam connector PR.
BaseConnectoris now generic over the whole download result, not over the item type of a list. A connector that fetches one handle returns the handle and takes it inconvert.What changes
downloadreturns one value of any type. ptb_xl, sleep_edfx, ecg_qa_cot and sleep_cot return their handle, soreturn [source]andraw_refs[0]are gone. test_mean returnsNone.list[...]: the Hugging Face base (list[HubFileRef]), har_cot and hello_world.composeandconvertis positional-only, so a connector can give it its own name.Breaking changes
A connector outside this repository that subclasses
BaseConnector[T]must change its type argument tolist[T], or return one value.Checks
make checkandmake test-connectorspass.