Repository navigation
CI: Test-braindecode runs braindecode's MOABB tests and examples instead of its whole suite - #1337
Open
bruAristimunha wants to merge 1 commit into
Open
bruAristimunha wants to merge 1 commit into
bruAristimunha wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-braindecodehas been red since 25 Oct. Six of its runs, including the 1 Nov run (41341915425), stopped 10-14 min intopytestwith "The runner has received a shutdown signal". The cause is memory. The step runs braindecode's whole default suite, about 8.3k tests covering its model zoo, with-n autoon the 16 GBubuntu-latestrunner. Each xdist worker grows to 4-7 GB and does not shrink.We replayed the step's commands in a 4-CPU pod with a 16 GiB limit:
-n 4: 7 workers were OOM-killed.-n 2: 1 worker was killed.The 29 Oct failures, in the TorchScript tests of the filter-bank models on torch 2.15, were fixed in braindecode by braindecode/braindecode#1501.
This PR keeps only the MOABB integration in the job:
pytest test/ -n 2 -k moabb: braindecode's MOABB tests (6 passed and 3 skipped in 18 s in our replay);plot_moabb_dataset_example,plot_bcic_iv_2a_moabb_trial,plot_bcic_iv_2a_moabb_croppedandplot_moabb_benchmark(about 2 min in total in our replay);timeout-minutes: 60on the job.braindecode's own CI still runs its full suite. On MOABB develop, braindecode 1.8.1 and braindecode master gave the same results for MOABB's tests, braindecode's MOABB tests and these four examples.