Skip to content

CSTACKEX-362:ONTAP NFS snapshot of detached volume is incorrectly processed as an image-store snapshot #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sp16743 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CSTACKEX-362:ONTAP NFS snapshot of detached volume is incorrectly processed as an image-store snapshot #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1775,20 +1775,18 @@ private void postSnapshotDirectlyToSecondary(SnapshotInfo snapshot, SnapshotInfo
}

/**
* Returns true when a volume snapshot on NetApp ONTAP is explicitly kept on managed primary/array storage.
* Returns true for volume snapshots on NetApp ONTAP managed primary/array storage.
*
* <p>For ONTAP managed pools, {@link #updateSnapshotPayload} defaults {@code locationType} to
* {@link Snapshot.LocationType#PRIMARY}. ONTAP volume snapshots therefore stay on the FlexVol
* on primary — they are not moved or mirrored to secondary storage. The primary
* {@code snapshot_data_store} row must remain so volume-snapshot DELETE uses
* {@code StorageSystemSnapshotStrategy} and the primary datastore driver.</p>
* <p>ONTAP volume snapshots stay on the FlexVol on primary — they are not moved or
* mirrored to secondary storage. The primary {@code snapshot_data_store} row must
* remain so volume-snapshot DELETE uses {@code StorageSystemSnapshotStrategy} and
* the primary datastore driver.</p>
*
* <p>Other managed storage providers are not affected by this check.</p>
*/
private boolean isManagedPrimaryLocationSnapshot(StoragePool storagePool, CreateSnapshotPayload payload) {
return storagePool != null && storagePool.isManaged()
&& DataStoreProvider.ONTAP_PLUGIN_NAME.equals(storagePool.getStorageProviderName())
&& Snapshot.LocationType.PRIMARY.equals(payload.getLocationType());
&& DataStoreProvider.ONTAP_PLUGIN_NAME.equals(storagePool.getStorageProviderName());
}

@Override
Expand Down
Loading