Repository navigation
Conversation
…cessed as an image-store snapshot
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.78% |
| Branch coverage | 20.08% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
piyush5netapp
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ONTAP volume snapshots should always remain on the ONTAP primary storage pool.
When taking a snapshot of an ONTAP NFS volume that is not attached to a VM, CloudStack successfully creates the FlexVol snapshot on ONTAP primary storage but incorrectly processes it as an image-store snapshot.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before the fix:

After the fix:

How Has This Been Tested?
-Created an NFS snapshot from an attached volume.
-Created an NFS snapshot from a detached volume.
-Created an iSCSI snapshot from an attached volume.
-Created an iSCSI snapshot from a detached volume.
-Verified each snapshot reached BackedUp.
-Verified each snapshot had location_type=PRIMARY.
-Verified no image-store reference was created.
How did you try to break this feature and the system with this change?