test(approval-controller): assert the error codes the expectations describe

[cryptodev-2s]

Explanation

getError returned a plain object, and toThrow given a plain object compares only its message. Every error code in this file was decoration: swapping one for a wrong value keeps the suite green.

These expectations now read the thrown error and assert message and code. The code is asserted unconditionally, so the paths that throw a plain Error are pinned to having none. Every code already in the file was correct, so nothing changes behaviourally, they are simply checked now.

rejects.toThrow(error) has the same blind spot for a custom Error subclass, so the one rejection path asserts the caller's error by identity instead.

Mutation checked: wrong code, unexpected code, missing code, nothing thrown, and a non Error all fail as they should.

References

• Split out of the Vitest migration, where Vitest compares a thrown value strictly and the old shape cannot match at all. Landing it here on Jest keeps that migration mechanical: test: run approval-controller on Vitest #10549's diff for this file drops from roughly 280 changed lines to 19.

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
  • Not applicable, test only change. Carries the no-changelog label.
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
  • None.

---

Note

Low Risk
Test-only changes to ApprovalController; no production code or runtime behavior changes.

Overview
ApprovalController tests now verify thrown errors’ messages and JSON-RPC code values, not only messages via Jest’s plain-object toThrow matching.

getError returns an ExpectedError descriptor (message + optional code), and a new expectToThrowError helper runs the operation once, catches the real Error, and asserts both fields (including code === undefined where no code is expected). Validation and “unknown id” cases across add, getApprovalCount, hasRequest, acceptRequest, rejectRequest, and updateRequestState were switched to this pattern.

The clearRequests rejection test now uses rejects.toBe(rejectionError) so the propagated JsonRpcError is checked by identity (and thus code), not only message/class via rejects.toThrow. oxlint-suppressions.json drops related lint suppressions for this test file.

^{Reviewed by Cursor Bugbot for commit bcbf6e0. Bugbot is set up for automated code reviews on this repo. Configure here.}

The merge-base changed after approval.