test: run approval-controller on Vitest

[cryptodev-2s]

Explanation

Moves @metamask/approval-controller to Vitest. One of a stack on top of #10546, which added Vitest without migrating anything.

Add vitest.config.mts, delete jest.config.cjs, swap the test scripts and dev dependencies, point the package tsconfig off the repo wide types: ["jest"], and rewrite the test files (jest.* to vi.*, jest.Mocked to the imported Vitest type, requireActual to an awaited importActual, and an explicit vitest import per file since globals is off).

The error expectations needed a real change, because Vitest compares a thrown value strictly and the old toThrow(plainObject) cannot match a JsonRpcError. That is split into #10576 so it lands on Jest and is reviewed on its own; with it in place the diff here is mechanical.

Tests pass with coverage thresholds enforced. yarn lint and yarn constraints are green on this branch alone.

References

• Stacked on test: add Vitest alongside Jest #10546, which explains the shared setup

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
  • Not applicable, test only change. Carries the no-changelog label.
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
  • None.

---

Note

Low Risk
Test-only and tooling changes; no production code in ApprovalController is modified.

Overview
Migrates @metamask/approval-controller from Jest to Vitest as part of the repo-wide test runner rollout (stacked on shared Vitest package config).

The package drops jest.config.cjs and adds vitest.config.mjs merged from vitest.config.packages.mjs, keeping 100% coverage thresholds. package.json test scripts and devDependencies swap Jest/ts-jest for Vitest; @metamask/approval-controller is removed from test-runners.cjs’s Jest package list.

ApprovalController.test.ts is updated mechanically: jest.* → vi.*, explicit vitest imports (globals off), flushPromises from tests/vitest/helpers.js, and package tsconfig.json sets types: [] so repo-wide Jest types do not apply. Lint suppressions drop the Jest config entry and add vitest/no-conditional-in-test for the test file.

^{Reviewed by Cursor Bugbot for commit 6a453a3. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit e32a39c. Configure here.}