Skip to content

test: run keyring-controller on Vitest #10552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cryptodev-2s wants to merge 6 commits into
base: main
Choose a base branch
from
Open

test: run keyring-controller on Vitest #10552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23939c7
test: run keyring-controller on Vitest
cryptodev-2s Oct 15, 2026
f60770b
test: drop the project name comment from the package config
cryptodev-2s Oct 16, 2026
1f6be78
test: name the Vitest configs .js since the repo is ESM
cryptodev-2s Oct 16, 2026
dac84c9
test: update the test scripts after rebasing onto main
cryptodev-2s Oct 16, 2026
de913b1
test: point the lint directives at the Vitest rules
cryptodev-2s Oct 16, 2026
a470d9c
fix: drop useless jsdoc
cryptodev-2s Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion knip.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ const config: KnipConfig = {
ignoreBinaries: ['sysctl'],
},
'packages/keyring-controller': {
ignoreDependencies: ['@metamask/controller-utils'],
ignoreDependencies: ['@metamask/controller-utils', 'uuid'],
},
'packages/local-node-utils': {
// `sysctl` is an external system binary, not an npm package.
Expand Down
10 changes: 4 additions & 6 deletions oxlint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3297,11 +3297,6 @@
"count": 11
}
},
"packages/keyring-controller/jest.config.cjs": {
"import/unambiguous": {
"count": 1
}
},
"packages/keyring-controller/src/KeyringController.test.ts": {
"typescript/no-unsafe-argument": {
"count": 1
Expand All @@ -3316,10 +3311,13 @@
"count": 1
},
"typescript/no-unsafe-return": {
"count": 2
"count": 1
},
"typescript/unbound-method": {
"count": 19
},
"vitest/no-conditional-in-test": {
"count": 2
}
},
"packages/keyring-controller/src/KeyringController.ts": {
Expand Down
26 changes: 0 additions & 26 deletions packages/keyring-controller/jest.config.cjs
View file
Open in desktop

This file was deleted.

15 changes: 6 additions & 9 deletions packages/keyring-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@
"messenger-action-types:check": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
"test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
"test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",
"test:verbose": "NODE_OPTIONS=--experimental-vm-modules jest --verbose",
"test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch"
"test": "vitest",
"test:clean": "vitest --clearCache",
"test:verbose": "vitest --reporter=verbose",
"test:watch": "vitest --watch"
},
"dependencies": {
"@ethereumjs/util": "^9.1.0",
Expand Down Expand Up @@ -75,16 +75,13 @@
"@metamask/auto-changelog": "^6.2.1",
"@metamask/keyring-utils": "^5.0.0",
"@metamask/scure-bip39": "^2.1.1",
"@types/jest": "^30.0.0",
"@typescript/native": "npm:typescript@^7.0.2",
"deepmerge": "^4.3.1",
"jest": "^30.5.2",
"rimraf": "^6.1.3",
"ts-jest": "^29.4.14",
"typedoc": "^0.28.20",
"typedoc-plugin-missing-exports": "^4.1.4",
"typescript": "npm:@typescript/typescript6@^6.0.2",
"uuid": "^11.1.1"
"uuid": "^11.1.1",
"vitest": "^5.0.0"
},
"engines": {
"node": "^22.14.0 || ^24"
Expand Down
Loading
Loading