Repository navigation
test: run keyring-controller on Vitest - #10552
Open
cryptodev-2s wants to merge 1 commit into
Open
cryptodev-2s wants to merge 1 commit into
cryptodev-2s wants to merge 1 commit into
Conversation
cryptodev-2s
added this pull request to stack #10557
September 28, 2026 20:19
2 of 4 tasks
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
September 29, 2026 08:11
68d12f9 to
675508f
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
2 times, most recently
from
September 29, 2026 09:02
13cd0c5 to
67d664b
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
2 times, most recently
from
September 29, 2026 14:38
44ee6e0 to
9f54633
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
September 29, 2026 14:38
67d664b to
19b538e
Compare
cryptodev-2s
removed this pull request from stack #10557
September 29, 2026 14:40
cryptodev-2s
added this pull request to stack #10578
September 29, 2026 14:41
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
September 30, 2026 07:04
19b538e to
3b9fa5f
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
2 times, most recently
from
October 5, 2026 10:48
562489c to
5cc065d
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 5, 2026 10:48
3b9fa5f to
2a0fcab
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 12, 2026 14:02
2a0fcab to
c101a7a
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 12, 2026 14:02
5cc065d to
4e2a256
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 12, 2026 15:43
c101a7a to
d6f72bf
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 12, 2026 15:43
4e2a256 to
b5e5992
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 14, 2026 09:23
d6f72bf to
b73f918
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 14, 2026 09:24
b5e5992 to
0e78d97
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 14, 2026 12:47
b73f918 to
655bb71
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
2 times, most recently
from
October 14, 2026 12:53
02a0548 to
1ee0916
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 14, 2026 13:44
94f8988 to
c0a4cda
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 14, 2026 13:44
1ee0916 to
66e6e3a
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 14, 2026 18:11
eac8ba0 to
c533375
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 14, 2026 18:11
bb503c1 to
6af29a3
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 14, 2026 20:18
c533375 to
7d298b8
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 14, 2026 20:18
6af29a3 to
ae1b276
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 14, 2026 20:37
7d298b8 to
e282b91
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
2 times, most recently
from
October 14, 2026 20:59
9fe575f to
5132c58
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 14, 2026 20:59
e282b91 to
0521230
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 14, 2026 21:27
5132c58 to
6020c05
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
2 times, most recently
from
October 14, 2026 22:48
c1ad23d to
fd6ff54
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 14, 2026 22:48
6020c05 to
c962a7e
Compare
cryptodev-2s
removed this pull request from stack #10578
October 14, 2026 22:51
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 15, 2026 10:36
c962a7e to
828cf37
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
2 times, most recently
from
October 15, 2026 11:20
83be520 to
efde443
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 15, 2026 11:20
828cf37 to
2dcc5b9
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 15, 2026 11:50
efde443 to
c0fd4d7
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 15, 2026 11:50
2dcc5b9 to
4fe325d
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 15, 2026 12:20
c0fd4d7 to
b346698
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 15, 2026 12:20
4fe325d to
ae3585d
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 15, 2026 13:21
b346698 to
a2673d1
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 15, 2026 13:21
ae3585d to
4665ce9
Compare
cryptodev-2s
force-pushed
the
test/vitest-accounts-controller
branch
from
October 15, 2026 14:48
a2673d1 to
f73bc66
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 15, 2026 14:48
4665ce9 to
83f3081
Compare
cryptodev-2s
changed the base branch from
test/vitest-accounts-controller
to
test/vitest-setup
October 15, 2026 14:56
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
2 times, most recently
from
October 15, 2026 20:07
cf96160 to
656703a
Compare
cryptodev-2s
force-pushed
the
test/vitest-keyring-controller
branch
from
October 15, 2026 23:52
656703a to
dba4dd3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Moves
@metamask/keyring-controllerto Vitest. One of a stack on top of #10546, which added Vitest without migrating anything.Add
vitest.config.mts, deletejest.config.cjs, swap the test scripts and dev dependencies, point the package tsconfig off the repo widetypes: ["jest"], and rewrite the test files (jest.*tovi.*,jest.Mockedto the imported Vitest type,requireActualto an awaitedimportActual, and an explicitvitestimport per file sinceglobalsis off).knip.config.mtsgains auuidignore: here it is only ever a module name string, invi.mockandvi.importActual, which knip does not trace. Coverage thresholds restated at measured values. Istanbul on esbuild output counts statements slightly differently from babel onts-jestoutput, within about a point.Tests pass with coverage thresholds enforced.
yarn lintandyarn constraintsare green on this branch alone.References
Checklist
no-changeloglabel.Note
Low Risk
Test-only and build-tooling changes; no production KeyringController runtime behavior is modified.
Overview
@metamask/keyring-controllermoves off Jest onto Vitest:jest.config.cjsis removed,vitest.config.mjsis added (with coverage thresholds retuned for Istanbul/esbuild), andpackage.jsontest scripts and devDependencies swap Jest for Vitest.Test code is updated mechanically—
jest.*→vi.*, explicitvitestimports (globals off),vi.importActualfor theuuidmock, andtsconfig.jsonsetstypes: []so repo-wide Jest types do not apply. Smaller test files andmockErc4337Keyringget the same treatment.Tooling follows the package:
@metamask/keyring-controlleris dropped from the Jest workspace list intest-runner-package-map.cjs,knipignoresuuidas a mock module string, andoxlint-suppressions.jsondrops the deleted Jest config entry and adjusts test-file counts.Reviewed by Cursor Bugbot for commit dba4dd3. Bugbot is set up for automated code reviews on this repo. Configure here.