Repository navigation
Clean up config files and unused test files - #3109
Open
antonwolfy wants to merge 6 commits into
Open
antonwolfy wants to merge 6 commits into
antonwolfy wants to merge 6 commits into
Conversation
check-case-conflict was listed twice; keep the entry in the Git group.
The job pushes a branch with the updated pins and opens a pull request from it, which needs contents: write and pull-requests: write.
Without it the installed dpnp.tests.third_party was an implicit namespace package, unlike in the source tree.
They import modules that no longer exist, so they were always skipped, and nothing else uses them.
It only called the tests_external runner.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
October 15, 2026 14:02
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/3109/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev14=np2py314h8d9cdd5_10 ran successfully. |
Collaborator
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few small cleanups, one commit per change:
check-case-conflictwas listed twice in.pre-commit-config.yaml; the entry in the Git group is kept.bump-sycl-deps.ymlgrantscontents: writeandpull-requests: writewithout saying why; it now has a comment for each, like the other workflows. They are needed to push the branch with the updated pins and to open a pull request from it..flake8listeddpnp/dpnp_algo/__init__.py: F401twice inper-file-ignores.dpnp/tests/third_party/__init__.py. Thepackage_dataglobs coveredtests/third_party/cupy/andtests/third_party/cupyx/but not the (empty)__init__.pyoftests/third_party/itself, so in an installed packagedpnp.tests.third_partywas an implicit namespace package, unlike in the source tree. The newtests/third_party/*.pyglob adds only that file.dpnp/tests/third_party/intel/. They import modules that no longer exist (e.g.dpctl.tensor.numpy_usm_shared), so all three were always skipped, and nothing else uses them. The__sycl_usm_array_interface__interoperability they were meant to check is covered by thedpnp.tensortests.dpnp/tests/third_party/numpy_ext/. It only called thetests_externalrunner.pre-commit run --all-filespasses with these changes.